diff options
| author | Wander Lairson Costa <wcosta@mozilla.com> | 2017-02-10 04:10:48 -0200 |
|---|---|---|
| committer | Ian Lance Taylor <iant@golang.org> | 2017-02-17 14:36:27 +0000 |
| commit | 79f6a5c7bd684f2e6007ee505b522440beb86bf0 (patch) | |
| tree | dd5f9c8bd97279e54569e2c0029c562226d1e2df /src/syscall/exec_bsd.go | |
| parent | 708ba22a0c7b6c2e8f46fccb35998c21c60629b9 (diff) | |
| download | go-79f6a5c7bd684f2e6007ee505b522440beb86bf0.tar.xz | |
syscall: only call setgroups if we need to
If the caller set ups a Credential in os/exec.Command,
os/exec.Command.Start will end up calling setgroups(2), even if no
supplementary groups were given.
Only root can call setgroups(2) on BSD kernels, which causes Start to
fail for non-root users when they try to set uid and gid for the new
process.
We fix by introducing a new field to syscall.Credential named
NoSetGroups, and setgroups(2) is only called if it is false.
We make this field with inverted logic to preserve backward
compatibility.
RELNOTES=yes
Change-Id: I3cff1f21c117a1430834f640ef21fd4e87e06804
Reviewed-on: https://go-review.googlesource.com/36697
Reviewed-by: Ian Lance Taylor <iant@golang.org>
Diffstat (limited to 'src/syscall/exec_bsd.go')
| -rw-r--r-- | src/syscall/exec_bsd.go | 8 |
1 files changed, 5 insertions, 3 deletions
diff --git a/src/syscall/exec_bsd.go b/src/syscall/exec_bsd.go index 317645fae5..31a4099559 100644 --- a/src/syscall/exec_bsd.go +++ b/src/syscall/exec_bsd.go @@ -146,9 +146,11 @@ func forkAndExecInChild(argv0 *byte, argv, envv []*byte, chroot, dir *byte, attr if ngroups > 0 { groups = uintptr(unsafe.Pointer(&cred.Groups[0])) } - _, _, err1 = RawSyscall(SYS_SETGROUPS, ngroups, groups, 0) - if err1 != 0 { - goto childerror + if !cred.NoSetGroups { + _, _, err1 = RawSyscall(SYS_SETGROUPS, ngroups, groups, 0) + if err1 != 0 { + goto childerror + } } _, _, err1 = RawSyscall(SYS_SETGID, uintptr(cred.Gid), 0, 0) if err1 != 0 { |