diff options
| author | Roland Shoemaker <bracewell@google.com> | 2026-01-09 11:12:01 -0800 |
|---|---|---|
| committer | Cherry Mui <cherryyz@google.com> | 2026-03-05 17:05:07 -0800 |
| commit | fb16297ae571a232e46a67e6e40027f1f82ef6ec (patch) | |
| tree | b7e6af55fa6024240fa080981913cb47834e560e /src/runtime | |
| parent | 36d8b15842748194c4a2ce7e9cf46c65a958283c (diff) | |
| download | go-fb16297ae571a232e46a67e6e40027f1f82ef6ec.tar.xz | |
html/template: properly escape URLs in meta content attributes
The meta tag can include a content attribute that contains URLs, which
we currently don't escape if they are inserted via a template action.
This can plausibly lead to XSS vulnerabilities if untrusted data is
inserted there, the http-equiv attribute is set to "refresh", and the
content attribute contains an action like `url={{.}}`.
Track whether we are inside of a meta element, if we are inside of a
content attribute, _and_ if the content attribute contains "url=". If
all of those are true, then we will apply the same URL escaping that we
use elsewhere.
Also add a new GODEBUG, htmlmetacontenturlescape, to allow disabling this
escaping for cases where this behavior is considered safe. The behavior
can be disabled by setting htmlmetacontenturlescape=0.
Fixes CVE-2026-27142
Fixes #77954
Change-Id: I9bbca263be9894688e6ef1e9a8f8d2f4304f5873
Reviewed-on: https://go-internal-review.googlesource.com/c/go/+/3360
Reviewed-by: Neal Patel <nealpatel@google.com>
Reviewed-by: Nicholas Husin <husin@google.com>
Reviewed-on: https://go-review.googlesource.com/c/go/+/752181
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Diffstat (limited to 'src/runtime')
| -rw-r--r-- | src/runtime/metrics/doc.go | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/src/runtime/metrics/doc.go b/src/runtime/metrics/doc.go index 361e68f0b3..1e87b0a80e 100644 --- a/src/runtime/metrics/doc.go +++ b/src/runtime/metrics/doc.go @@ -302,6 +302,11 @@ Below is the full list of supported metrics, ordered lexicographically. package due to a non-default GODEBUG=gotestjsonbuildtext=... setting. + /godebug/non-default-behavior/htmlmetacontenturlescape:events + The number of non-default behaviors executed by + the html/template package due to a non-default + GODEBUG=htmlmetacontenturlescape=... setting. + /godebug/non-default-behavior/http2client:events The number of non-default behaviors executed by the net/http package due to a non-default GODEBUG=http2client=... setting. |