diff options
| author | Matthew Dempsky <mdempsky@google.com> | 2021-08-23 11:40:56 -0700 |
|---|---|---|
| committer | Matthew Dempsky <mdempsky@google.com> | 2021-08-23 20:04:34 +0000 |
| commit | fa34678c67275a765a9b78443806c8144d88fe3d (patch) | |
| tree | 3926878cd461d66402d3772cf857ac7e45febf05 /src/runtime | |
| parent | 0a7f00ae239570d664488085f9c395919bc69066 (diff) | |
| download | go-fa34678c67275a765a9b78443806c8144d88fe3d.tar.xz | |
internal/buildcfg: change GOEXPERIMENT to always return non-empty string
Rather than returning "", we now return "," (which is a no-op). This
ensures that the returned string always overrides DefaultGOEXPERIMENT.
This fixes a bootstrapping issue where GOROOT_BOOTSTRAP was built with
"GOEXPERIMENT=fieldtrack ./make.bash". cmd/dist sets GOEXPERIMENT=none
during bootstrapping, which was causing cmd/go to set GOEXPERIMENT=""
when executing cmd/compile; but then cmd/compile ignores the
environment variable (because it's empty) and instead uses
DefaultGOEXPERIMENT.
Fixes #47921.
Change-Id: I657ff6cdfb294a94f6a2f58c306ceed7f104416b
Reviewed-on: https://go-review.googlesource.com/c/go/+/344511
Run-TryBot: Matthew Dempsky <mdempsky@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Trust: Matthew Dempsky <mdempsky@google.com>
Reviewed-by: Heschi Kreinick <heschi@google.com>
Diffstat (limited to 'src/runtime')
0 files changed, 0 insertions, 0 deletions