diff options
| author | Lidong Yan <yldhome2d2@gmail.com> | 2025-11-21 11:14:46 +0800 |
|---|---|---|
| committer | Keith Randall <khr@golang.org> | 2025-11-23 09:07:32 -0800 |
| commit | e88be8a128d167c5ab91eabc998ab364370c702e (patch) | |
| tree | 15a8f3448352fc27d9a78fcfc445fb7a22492074 /src/runtime | |
| parent | a318843a2ad17d853b13599a73b2912a13474490 (diff) | |
| download | go-e88be8a128d167c5ab91eabc998ab364370c702e.tar.xz | |
runtime: fix stale comment for mheap/malloc
mheap use pageAlloc to manage free/scav address space instead of
using free/scav treap. The comment on mheap states mheap uses
treaps. Update the comment to reflect the use of pageAlloc.
In the fallback code when sizeSpecializedMalloc is enabled,
heapBitsInSpan is false. Update the comment to reflect that.
Change-Id: I50d2993c84e2c0312a925ab0a33065cc4cd41c41
Reviewed-on: https://go-review.googlesource.com/c/go/+/722700
Reviewed-by: Lidong Yan <yldhome2d2@gmail.com>
Reviewed-by: Keith Randall <khr@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Keith Randall <khr@golang.org>
Reviewed-by: Mark Freeman <markfreeman@google.com>
Diffstat (limited to 'src/runtime')
| -rw-r--r-- | src/runtime/malloc.go | 2 | ||||
| -rw-r--r-- | src/runtime/mheap.go | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/src/runtime/malloc.go b/src/runtime/malloc.go index d49dacaf68..4971e16c6a 100644 --- a/src/runtime/malloc.go +++ b/src/runtime/malloc.go @@ -1169,7 +1169,7 @@ func mallocgc(size uintptr, typ *_type, needzero bool) unsafe.Pointer { var x unsafe.Pointer var elemsize uintptr if sizeSpecializedMallocEnabled { - // we know that heapBitsInSpan is true. + // we know that heapBitsInSpan is false. if size <= maxSmallSize-gc.MallocHeaderSize { if typ == nil || !typ.Pointers() { x, elemsize = mallocgcSmallNoscan(size, typ, needzero) diff --git a/src/runtime/mheap.go b/src/runtime/mheap.go index d2ff063b00..0ccaadc891 100644 --- a/src/runtime/mheap.go +++ b/src/runtime/mheap.go @@ -56,7 +56,7 @@ const ( ) // Main malloc heap. -// The heap itself is the "free" and "scav" treaps, +// The heap use pageAlloc to manage free and scavenged pages, // but all the other global data is here too. // // mheap must not be heap-allocated because it contains mSpanLists, |