diff options
| author | Michael Anthony Knyszek <mknyszek@google.com> | 2022-09-07 20:11:00 +0000 |
|---|---|---|
| committer | Gopher Robot <gobot@golang.org> | 2022-09-08 16:06:00 +0000 |
| commit | e28cc362a825b297fa8a10dc95d7c0d2e2b21dfc (patch) | |
| tree | d39f0264ff9490ea1b69850ab3e37a4adcb05af8 /src/runtime | |
| parent | 1c59199c919419293075ac9c93b27b033e2733f9 (diff) | |
| download | go-e28cc362a825b297fa8a10dc95d7c0d2e2b21dfc.tar.xz | |
runtime: remove alignment padding in mheap and pageAlloc
All subfields use atomic types to ensure alignment, so there's no more
need for these fields.
Change-Id: Iada4253f352a074073ce603f1f6b07cbd5b7c58a
Reviewed-on: https://go-review.googlesource.com/c/go/+/429220
Run-TryBot: Michael Knyszek <mknyszek@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Auto-Submit: Michael Knyszek <mknyszek@google.com>
Reviewed-by: Keith Randall <khr@google.com>
Reviewed-by: Keith Randall <khr@golang.org>
Diffstat (limited to 'src/runtime')
| -rw-r--r-- | src/runtime/mheap.go | 6 | ||||
| -rw-r--r-- | src/runtime/mpagealloc.go | 2 |
2 files changed, 0 insertions, 8 deletions
diff --git a/src/runtime/mheap.go b/src/runtime/mheap.go index be53f7bd91..610011863b 100644 --- a/src/runtime/mheap.go +++ b/src/runtime/mheap.go @@ -65,8 +65,6 @@ type mheap struct { // could self-deadlock if its stack grows with the lock held. lock mutex - _ uint32 // 8-byte align pages so its alignment is consistent with tests. - pages pageAlloc // page allocation data structure sweepgen uint32 // sweep generation, see comment in mspan; written during STW @@ -84,8 +82,6 @@ type mheap struct { // access (since that may free the backing store). allspans []*mspan // all spans out there - // _ uint32 // align uint64 fields on 32-bit for atomics - // Proportional sweep // // These parameters represent a linear function from gcController.heapLive @@ -191,8 +187,6 @@ type mheap struct { base, end uintptr } - _ uint32 // ensure 64-bit alignment of central - // central free lists for small size classes. // the padding makes sure that the mcentrals are // spaced CacheLinePadSize bytes apart, so that each mcentral.lock diff --git a/src/runtime/mpagealloc.go b/src/runtime/mpagealloc.go index 83df7c5150..853d7fc9ca 100644 --- a/src/runtime/mpagealloc.go +++ b/src/runtime/mpagealloc.go @@ -267,8 +267,6 @@ type pageAlloc struct { // All access is protected by the mheapLock. inUse addrRanges - _ uint32 // Align scav so it's easier to reason about alignment within scav. - // scav stores the scavenger state. scav struct { // index is an efficient index of chunks that have pages available to |