diff options
| author | Ian Lance Taylor <iant@golang.org> | 2022-08-19 14:43:47 -0700 |
|---|---|---|
| committer | Gopher Robot <gobot@golang.org> | 2022-08-19 23:07:11 +0000 |
| commit | d05ce23756573c6dc2c5026d936f2ef6ac140ee2 (patch) | |
| tree | ed20aa48e0c3dbf2e60c6a41ff82f020c5ca3d44 /src/runtime | |
| parent | f3563bc55c7029473aeaf228171ecd06f1317532 (diff) | |
| download | go-d05ce23756573c6dc2c5026d936f2ef6ac140ee2.tar.xz | |
misc/cgo/testcarchive: permit SIGQUIT for TestSignalForwardingExternal
Occasionally the signal will be sent to a Go thread, which will cause
the program to exit with SIGQUIT rather than SIGSEGV.
Add TestSignalForwardingGo to test the case where the signal is
expected to be delivered to a Go thread.
This is a roll forward of CL 419014 which was rolled back in CL 424954.
This CL differs from 419014 in that it skips TestSignalForwardingGo
on darwin-amd64.
Fixes #53907
Change-Id: I5df3fd610c068df3bd48d9b3d7a9379248b97999
Reviewed-on: https://go-review.googlesource.com/c/go/+/425002
Run-TryBot: Ian Lance Taylor <iant@google.com>
Reviewed-by: Bryan Mills <bcmills@google.com>
Run-TryBot: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@google.com>
Auto-Submit: Ian Lance Taylor <iant@google.com>
Diffstat (limited to 'src/runtime')
| -rw-r--r-- | src/runtime/signal_darwin_amd64.go | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/src/runtime/signal_darwin_amd64.go b/src/runtime/signal_darwin_amd64.go index abc212ad51..20544d8489 100644 --- a/src/runtime/signal_darwin_amd64.go +++ b/src/runtime/signal_darwin_amd64.go @@ -84,6 +84,10 @@ func (c *sigctxt) fixsigcode(sig uint32) { // in real life, people will probably search for it and find this code. // There are no Google hits for b01dfacedebac1e or 0xb01dfacedebac1e // as I type this comment. + // + // Note: if this code is removed, please consider + // enabling TestSignalForwardingGo for darwin-amd64 in + // misc/cgo/testcarchive/carchive_test.go. if c.sigcode() == _SI_USER { c.set_sigcode(_SI_USER + 1) c.set_sigaddr(0xb01dfacedebac1e) |