diff options
| author | Austin Clements <austin@google.com> | 2023-06-06 13:07:37 -0400 |
|---|---|---|
| committer | Gopher Robot <gobot@golang.org> | 2023-06-06 17:27:36 +0000 |
| commit | b7fc272ca95bce716ba1bab1bc2490b2f31edcb5 (patch) | |
| tree | 2ca5c83b8525d0d0820785c3ca5ab780418676db /src/runtime | |
| parent | 89184adb9a834911af8d2f786b7ed454757c08e7 (diff) | |
| download | go-b7fc272ca95bce716ba1bab1bc2490b2f31edcb5.tar.xz | |
runtime: skip TestCrashDumpsAllThreads with mayMoreStackPreempt
This test is flaky with in mayMoreStackPreempt mode. This is probably
revealing a real bug in the scheduler, but since it seems to only
affect TestCrashDumpsAllThreads, which is itself testing a debug mode,
I don't think this is high priority.
Updates #55160.
Change-Id: Iac558c098930ad8d4392b1e82b34f55eaec77c48
Reviewed-on: https://go-review.googlesource.com/c/go/+/501229
Reviewed-by: Michael Pratt <mpratt@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Austin Clements <austin@google.com>
Auto-Submit: Austin Clements <austin@google.com>
Diffstat (limited to 'src/runtime')
| -rw-r--r-- | src/runtime/crash_unix_test.go | 11 |
1 files changed, 10 insertions, 1 deletions
diff --git a/src/runtime/crash_unix_test.go b/src/runtime/crash_unix_test.go index a7d6624789..07060b8fab 100644 --- a/src/runtime/crash_unix_test.go +++ b/src/runtime/crash_unix_test.go @@ -14,6 +14,7 @@ import ( "os/exec" "runtime" "runtime/debug" + "strings" "sync" "syscall" "testing" @@ -75,12 +76,20 @@ func TestCrashDumpsAllThreads(t *testing.T) { testenv.MustHaveGoBuild(t) + if strings.Contains(os.Getenv("GCFLAGS"), "mayMoreStackPreempt") { + // This test occasionally times out in this debug mode. This is probably + // revealing a real bug in the scheduler, but since it seems to only + // affect this test and this is itself a test of a debug mode, it's not + // a high priority. + testenv.SkipFlaky(t, 55160) + } + exe, err := buildTestProg(t, "testprog") if err != nil { t.Fatal(err) } - cmd := exec.Command(exe, "CrashDumpsAllThreads") + cmd := testenv.Command(t, exe, "CrashDumpsAllThreads") cmd = testenv.CleanCmdEnv(cmd) cmd.Env = append(cmd.Env, "GOTRACEBACK=crash", |