diff options
| author | Russ Cox <rsc@golang.org> | 2018-07-09 10:55:36 -0400 |
|---|---|---|
| committer | Russ Cox <rsc@golang.org> | 2018-07-09 15:12:53 +0000 |
| commit | a41d21695cad0e30d9c006198cd7edd8c38bf885 (patch) | |
| tree | 82730e8fbf7f0f5a34c60cfaf00677f96c72c0bc /src/runtime | |
| parent | 7254cfc37b3a93a6e83dae22c4bfd6f777edb97e (diff) | |
| download | go-a41d21695cad0e30d9c006198cd7edd8c38bf885.tar.xz | |
regexp: revert "use sync.Pool to cache regexp.machine objects"
Revert CL 101715.
The size of a sync.Pool scales linearly with GOMAXPROCS,
making it inappropriate to put a sync.Pool in any individually
allocated object, as the sync.Pool documentation explains.
The change also broke DeepEqual on regexps.
I have a cleaner way to do this with global sync.Pools but it's
too late in the cycle. Will revisit in Go 1.12. For now, revert.
Fixes #26219.
Change-Id: Ie632e709eb3caf489d85efceac0e4b130ec2019f
Reviewed-on: https://go-review.googlesource.com/122596
Run-TryBot: Russ Cox <rsc@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Diffstat (limited to 'src/runtime')
0 files changed, 0 insertions, 0 deletions