diff options
| author | Michael Anthony Knyszek <mknyszek@google.com> | 2025-12-03 22:52:45 +0000 |
|---|---|---|
| committer | Michael Knyszek <mknyszek@google.com> | 2025-12-05 11:35:47 -0800 |
| commit | 8947f092a8427674b7628003b873f57d3b6cdd83 (patch) | |
| tree | 28e43ce5106f86b1df366ab6f09ed5bf814d3d68 /src/runtime | |
| parent | 44cb82449e7f24530fe0fe0bf8261ba9e0e4e7d8 (diff) | |
| download | go-8947f092a8427674b7628003b873f57d3b6cdd83.tar.xz | |
runtime: skip mayMoreStackMove in goroutine leak tests
mayMoreStackMove may introduce more scheduler chaos because of all the
stack movement (not as much as mayMoreStackPreempt) so let's disable the
tests here too, since we have evidence that they can produce false
negatives under this configuration. Though we're not 100% sure why this
is happening yet, let's at least stop the flow of flaky failures.
For #75729.
Change-Id: I16d13dba9a61fbd47563b21cbf188e4754f58213
Reviewed-on: https://go-review.googlesource.com/c/go/+/726526
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Michael Pratt <mpratt@google.com>
Diffstat (limited to 'src/runtime')
| -rw-r--r-- | src/runtime/goroutineleakprofile_test.go | 11 |
1 files changed, 7 insertions, 4 deletions
diff --git a/src/runtime/goroutineleakprofile_test.go b/src/runtime/goroutineleakprofile_test.go index a0446b36f0..9ab92d17c4 100644 --- a/src/runtime/goroutineleakprofile_test.go +++ b/src/runtime/goroutineleakprofile_test.go @@ -14,10 +14,13 @@ import ( ) func TestGoroutineLeakProfile(t *testing.T) { - if strings.Contains(os.Getenv("GOFLAGS"), "mayMoreStackPreempt") { - // Some tests have false negatives under mayMoreStackPreempt. This may be a test-only issue, - // but needs more investigation. - testenv.SkipFlaky(t, 75729) + // Some tests have false negatives under mayMoreStackPreempt and mayMoreStackMove. + // This may be a test-only issue in that they're just sensitive to scheduling, but it + // needs more investigation. + for _, cfg := range []string{"mayMoreStackPreempt", "mayMoreStackMove"} { + if strings.Contains(os.Getenv("GOFLAGS"), cfg) { + testenv.SkipFlaky(t, 75729) + } } // Goroutine leak test case. |