diff options
| author | Daniel Morsing <daniel.morsing@gmail.com> | 2025-12-10 10:07:56 +0000 |
|---|---|---|
| committer | David Chase <drchase@google.com> | 2025-12-12 12:26:44 -0800 |
| commit | 63fced531c0d702554fcfda41f9016701a6859c6 (patch) | |
| tree | 5475bb413e0f6bc9ea9aa417bf5e8ae173573fc9 /src/runtime | |
| parent | 6455afbc6f93e7ddc5ffde38b563c4e1a6821d22 (diff) | |
| download | go-63fced531c0d702554fcfda41f9016701a6859c6.tar.xz | |
runtime/secret: restore goroutine behavior to proposal
During review of CL 704615, a suggestion was made that spawning a
goroutine inside a call to secret.Do result in a panic. I agreed with
this at the time, but had missed that this had been extensively
discussed on the proposal. Revert the behavior back to what was agreed
upon.
Change-Id: Ifaa9e24bd03ecbd870ae2217137d1a9527c96842
Reviewed-on: https://go-review.googlesource.com/c/go/+/728920
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: David Chase <drchase@google.com>
Reviewed-by: Roland Shoemaker <roland@golang.org>
Diffstat (limited to 'src/runtime')
| -rw-r--r-- | src/runtime/proc.go | 4 | ||||
| -rw-r--r-- | src/runtime/secret/secret.go | 2 |
2 files changed, 1 insertions, 5 deletions
diff --git a/src/runtime/proc.go b/src/runtime/proc.go index 465a1adb60..5ea96f03f5 100644 --- a/src/runtime/proc.go +++ b/src/runtime/proc.go @@ -5286,10 +5286,6 @@ func malg(stacksize int32) *g { // The compiler turns a go statement into a call to this. func newproc(fn *funcval) { gp := getg() - if goexperiment.RuntimeSecret && gp.secret > 0 { - panic("goroutine spawned while running in secret mode") - } - pc := sys.GetCallerPC() systemstack(func() { newg := newproc1(fn, gp, pc, false, waitReasonZero) diff --git a/src/runtime/secret/secret.go b/src/runtime/secret/secret.go index f669b98828..9eae22605f 100644 --- a/src/runtime/secret/secret.go +++ b/src/runtime/secret/secret.go @@ -28,7 +28,7 @@ import ( // - Currently only supported on linux/amd64 and linux/arm64. On unsupported // platforms, Do will invoke f directly. // - Protection does not extend to any global variables written by f. -// - Any attempt to launch a goroutine by f will result in a panic. +// - Protection does not extend to any new goroutines made by f. // - If f calls runtime.Goexit, erasure can be delayed by defers // higher up on the call stack. // - Heap allocations will only be erased if the program drops all |