diff options
| author | Damien Neil <dneil@google.com> | 2025-02-07 09:55:15 -0800 |
|---|---|---|
| committer | Gopher Robot <gobot@golang.org> | 2025-02-10 10:48:27 -0800 |
| commit | 3924fe92b61042df7bef5c19db0ab0316d111e9b (patch) | |
| tree | f658e7988d55e97f2972f5e7be994584645396de /src/runtime | |
| parent | a704d39b29dfc21599f644909c0f98bbfa745cb4 (diff) | |
| download | go-3924fe92b61042df7bef5c19db0ab0316d111e9b.tar.xz | |
runtime: establish happens-before between goroutine and bubble exit
synctest.Run waits for all bubbled goroutines to exit before returning.
Establish a happens-before relationship between the bubbled goroutines
exiting and Run returning.
For #67434
Change-Id: Ibda7ec2075ae50838c0851e60dc5b3c6f3ca70fb
Reviewed-on: https://go-review.googlesource.com/c/go/+/647755
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Auto-Submit: Damien Neil <dneil@google.com>
Reviewed-by: Michael Pratt <mpratt@google.com>
Diffstat (limited to 'src/runtime')
| -rw-r--r-- | src/runtime/synctest.go | 7 |
1 files changed, 7 insertions, 0 deletions
diff --git a/src/runtime/synctest.go b/src/runtime/synctest.go index 498c3b92dd..65bb15dfbb 100644 --- a/src/runtime/synctest.go +++ b/src/runtime/synctest.go @@ -182,6 +182,8 @@ func synctestRun(f func()) { sg.active++ for { if raceenabled { + // Establish a happens-before relationship between a timer being created, + // and the timer running. raceacquireg(gp, gp.syncGroup.raceaddr()) } unlock(&sg.mu) @@ -205,6 +207,11 @@ func synctestRun(f func()) { total := sg.total unlock(&sg.mu) + if raceenabled { + // Establish a happens-before relationship between bubbled goroutines exiting + // and Run returning. + raceacquireg(gp, gp.syncGroup.raceaddr()) + } if total != 1 { panic("deadlock: all goroutines in bubble are blocked") } |