diff options
| author | Keith Randall <khr@golang.org> | 2022-07-18 11:47:19 -0700 |
|---|---|---|
| committer | Keith Randall <khr@google.com> | 2022-08-08 16:58:57 +0000 |
| commit | 2493072db68a8f8b545bb2a6faebac0da0f01336 (patch) | |
| tree | aa3634bcab3894c6382b3c68c7340a43370e27ba /src/runtime | |
| parent | c3833a55433f4b2981253f64444fe5c3d1bc910a (diff) | |
| download | go-2493072db68a8f8b545bb2a6faebac0da0f01336.tar.xz | |
cmd/compile: avoid assignment conversion in append(a, b...)
There's no need for a and b to match types. The typechecker already
ensured that a and b are both slices with the same base type, or
a and b are (possibly named) []byte and string.
The optimization to treat append(b, make([], ...)) as a zeroing
slice extension doesn't fire when there's a OCONVNOP wrapping the make.
Fixes #53888
Change-Id: Ied871ed0bbb8e4a4b35d280c71acbab8103691bc
Reviewed-on: https://go-review.googlesource.com/c/go/+/418475
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Matthew Dempsky <mdempsky@google.com>
Reviewed-by: Cuong Manh Le <cuong.manhle.vn@gmail.com>
Reviewed-by: Keith Randall <khr@google.com>
Run-TryBot: Keith Randall <khr@golang.org>
Diffstat (limited to 'src/runtime')
| -rw-r--r-- | src/runtime/slice.go | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/runtime/slice.go b/src/runtime/slice.go index 9ca0adefd8..75f202fca0 100644 --- a/src/runtime/slice.go +++ b/src/runtime/slice.go @@ -194,7 +194,7 @@ func growslice(et *_type, old slice, cap int) slice { } if cap < old.cap { - panic(errorString("growslice: cap out of range")) + panic(errorString("growslice: len out of range")) } if et.size == 0 { @@ -284,7 +284,7 @@ func growslice(et *_type, old slice, cap int) slice { // print(len(s), "\n") // } if overflow || capmem > maxAlloc { - panic(errorString("growslice: cap out of range")) + panic(errorString("growslice: len out of range")) } var p unsafe.Pointer |