diff options
| author | Michael Pratt <mpratt@google.com> | 2024-09-17 16:30:04 -0400 |
|---|---|---|
| committer | Gopher Robot <gobot@golang.org> | 2024-10-30 15:05:37 +0000 |
| commit | 2220fd36368c96da3dd833bdc2bbd13be291216a (patch) | |
| tree | b4357eca1856c000e571d1eb5f9dec54d4258344 /src/runtime | |
| parent | 3a6795554daf96d4e01ab02f999a1ea7dde2660c (diff) | |
| download | go-2220fd36368c96da3dd833bdc2bbd13be291216a.tar.xz | |
runtime: add concurrent write checks to swissmap
This is the same design as existing maps.
For #54766.
Cq-Include-Trybots: luci.golang.try:gotip-linux-amd64-longtest-swissmap
Change-Id: I5f6ef5fea1e0f0616bcd90eaae7faee4cdac58c6
Reviewed-on: https://go-review.googlesource.com/c/go/+/616460
Reviewed-by: Keith Randall <khr@golang.org>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Auto-Submit: Michael Pratt <mpratt@google.com>
Reviewed-by: Keith Randall <khr@google.com>
Diffstat (limited to 'src/runtime')
| -rw-r--r-- | src/runtime/map_swiss.go | 4 |
1 files changed, 0 insertions, 4 deletions
diff --git a/src/runtime/map_swiss.go b/src/runtime/map_swiss.go index 42b964da24..2f48d29ac6 100644 --- a/src/runtime/map_swiss.go +++ b/src/runtime/map_swiss.go @@ -70,7 +70,6 @@ func makemap(t *abi.SwissMapType, hint int, m *maps.Map) *maps.Map { func mapaccess1(t *abi.SwissMapType, m *maps.Map, key unsafe.Pointer) unsafe.Pointer func mapaccess2(t *abi.SwissMapType, m *maps.Map, key unsafe.Pointer) (unsafe.Pointer, bool) { - // TODO: concurrent checks. if raceenabled && m != nil { callerpc := sys.GetCallerPC() pc := abi.FuncPCABIInternal(mapaccess2) @@ -121,7 +120,6 @@ func mapaccess2_fat(t *abi.SwissMapType, m *maps.Map, key, zero unsafe.Pointer) func mapassign(t *abi.SwissMapType, m *maps.Map, key unsafe.Pointer) unsafe.Pointer func mapdelete(t *abi.SwissMapType, m *maps.Map, key unsafe.Pointer) { - // TODO: concurrent checks. if raceenabled && m != nil { callerpc := sys.GetCallerPC() pc := abi.FuncPCABIInternal(mapdelete) @@ -153,7 +151,6 @@ func mapiterinit(t *abi.SwissMapType, m *maps.Map, it *maps.Iter) { } func mapiternext(it *maps.Iter) { - // TODO: concurrent checks. if raceenabled { callerpc := sys.GetCallerPC() racereadpc(unsafe.Pointer(it.Map()), callerpc, abi.FuncPCABIInternal(mapiternext)) @@ -164,7 +161,6 @@ func mapiternext(it *maps.Iter) { // mapclear deletes all keys from a map. func mapclear(t *abi.SwissMapType, m *maps.Map) { - // TODO: concurrent checks. if raceenabled && m != nil { callerpc := sys.GetCallerPC() pc := abi.FuncPCABIInternal(mapclear) |