diff options
| author | Tom Bergan <tombergan@google.com> | 2016-05-12 22:03:46 -0700 |
|---|---|---|
| committer | Brad Fitzpatrick <bradfitz@golang.org> | 2016-05-14 00:14:25 +0000 |
| commit | 19619c21c36d1695000f5b798241971dfdb2cc2d (patch) | |
| tree | 0551c88831dbaec9930fd945d345f6cc7d06720b /src/runtime | |
| parent | 0cc710dca63b79ed2dd6ce9375502e76e5fc0484 (diff) | |
| download | go-19619c21c36d1695000f5b798241971dfdb2cc2d.tar.xz | |
net, net/http: don't trace DNS dials
This fixes change https://go-review.googlesource.com/#/c/23069/, which
assumes all DNS requests are UDP. This is not true -- DNS requests can
be TCP in some cases. See:
https://tip.golang.org/src/net/dnsclient_unix.go#L154
https://en.wikipedia.org/wiki/Domain_Name_System#Protocol_transport
Also, the test code added by the above change doesn't actually test
anything because the test uses a faked DNS resolver that doesn't
actually make any DNS queries. I fixed that by adding another test
that uses the system DNS resolver.
Updates #12580
Change-Id: I6c24c03ebab84d437d3ac610fd6eb5353753c490
Reviewed-on: https://go-review.googlesource.com/23101
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Diffstat (limited to 'src/runtime')
0 files changed, 0 insertions, 0 deletions