diff options
| author | Filippo Valsorda <filippo@golang.org> | 2024-10-23 20:21:50 +0200 |
|---|---|---|
| committer | Gopher Robot <gobot@golang.org> | 2024-10-28 14:46:33 +0000 |
| commit | 0138c1abef3871b72e47d5909ce08c9218f61b16 (patch) | |
| tree | fc310e49c0f107c014ecb439d0c19d88bf07a4ab /src/runtime | |
| parent | 7a256adbafed8599d7c355422f50d4b95b60bf46 (diff) | |
| download | go-0138c1abef3871b72e47d5909ce08c9218f61b16.tar.xz | |
Revert "crypto/rand: add randcrash=0 GODEBUG"
A GODEBUG is actually a security risk here: most programs will start to
ignore errors from Read because they can't happen (which is the intended
behavior), but then if a program is run with GODEBUG=randcrash=0 it will
use a partial buffer in case an error occurs, which may be catastrophic.
Note that the proposal was accepted without the GODEBUG, which was only
added later.
This (partially) reverts CL 608435. I kept the tests.
Updates #66821
Change-Id: I3fd20f9cae0d34115133fe935f0cfc7a741a2662
Reviewed-on: https://go-review.googlesource.com/c/go/+/622115
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Carlos Amedee <carlos@golang.org>
Reviewed-by: Roland Shoemaker <roland@golang.org>
Auto-Submit: Filippo Valsorda <filippo@golang.org>
Reviewed-by: Daniel McCarney <daniel@binaryparadox.net>
Diffstat (limited to 'src/runtime')
| -rw-r--r-- | src/runtime/metrics/doc.go | 4 |
1 files changed, 0 insertions, 4 deletions
diff --git a/src/runtime/metrics/doc.go b/src/runtime/metrics/doc.go index 3d2cc6159f..906abb4102 100644 --- a/src/runtime/metrics/doc.go +++ b/src/runtime/metrics/doc.go @@ -306,10 +306,6 @@ Below is the full list of supported metrics, ordered lexicographically. The number of non-default behaviors executed by the math/rand package due to a non-default GODEBUG=randautoseed=... setting. - /godebug/non-default-behavior/randcrash:events - The number of non-default behaviors executed by the crypto/rand - package due to a non-default GODEBUG=randcrash=... setting. - /godebug/non-default-behavior/randseednop:events The number of non-default behaviors executed by the math/rand package due to a non-default GODEBUG=randseednop=... setting. |