diff options
| author | Michael Pratt <mpratt@google.com> | 2022-03-04 11:17:43 -0500 |
|---|---|---|
| committer | Michael Pratt <mpratt@google.com> | 2022-03-07 16:24:54 +0000 |
| commit | cc9d3f548a0265124766dfdb45e77cf05579219d (patch) | |
| tree | addea6aaa69141fc3d7676f8baa6eefc4dc89f1d /src/runtime/traceback.go | |
| parent | 63bd6f68e6cbb237b46a99775103758afaee370a (diff) | |
| download | go-cc9d3f548a0265124766dfdb45e77cf05579219d.tar.xz | |
runtime: print goid when throwing in gentraceback
This makes it easier to figure out where the crash is occurring.
Change-Id: Ie1f78a360367090dcd61c61b2a55c34f3e2ff2eb
Reviewed-on: https://go-review.googlesource.com/c/go/+/390034
Trust: David Chase <drchase@google.com>
Reviewed-by: David Chase <drchase@google.com>
Trust: Michael Pratt <mpratt@google.com>
Run-TryBot: Michael Pratt <mpratt@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Cherry Mui <cherryyz@google.com>
Diffstat (limited to 'src/runtime/traceback.go')
| -rw-r--r-- | src/runtime/traceback.go | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/runtime/traceback.go b/src/runtime/traceback.go index 0cdd53cc93..23bce2bf34 100644 --- a/src/runtime/traceback.go +++ b/src/runtime/traceback.go @@ -113,7 +113,7 @@ func gentraceback(pc0, sp0, lr0 uintptr, gp *g, skip int, pcbuf *uintptr, max in f := findfunc(frame.pc) if !f.valid() { if callback != nil || printing { - print("runtime: unknown pc ", hex(frame.pc), "\n") + print("runtime: g ", gp.goid, ": unknown pc ", hex(frame.pc), "\n") tracebackHexdump(gp.stack, &frame, 0) } if callback != nil { @@ -247,7 +247,7 @@ func gentraceback(pc0, sp0, lr0 uintptr, gp *g, skip int, pcbuf *uintptr, max in doPrint = false } if callback != nil || doPrint { - print("runtime: unexpected return pc for ", funcname(f), " called from ", hex(frame.lr), "\n") + print("runtime: g ", gp.goid, ": unexpected return pc for ", funcname(f), " called from ", hex(frame.lr), "\n") tracebackHexdump(gp.stack, &frame, lrPtr) } if callback != nil { |