aboutsummaryrefslogtreecommitdiff
path: root/src/runtime/trace2runtime.go
diff options
context:
space:
mode:
authorMichael Anthony Knyszek <mknyszek@google.com>2023-12-21 20:26:38 +0000
committerMichael Knyszek <mknyszek@google.com>2024-02-01 21:02:30 +0000
commit287f791845ac0311012814f4419d5e043c212d17 (patch)
treeb5e36c8fb4d584f42b7c14b74b5226b5e7b70073 /src/runtime/trace2runtime.go
parentd864eac249c6e8a10c47861b5820576887680f9b (diff)
downloadgo-287f791845ac0311012814f4419d5e043c212d17.tar.xz
runtime: fix trace EvGoStop Gosched reason to match function
Currently the stop reason for runtime.Gosched is labeled "runtime.GoSched" which doesn't actually match the function name. Fix the label to match the function name. This change doesn't regenerate the internal/trace/v2 tests, because regenerating the tests breaks summarization tests in internal/trace that rely on very specific details in the example traces that aren't guaranteed. Also, go122-gc-trace.test isn't generated at all, as it turns out. I'll fix this all up in a follow-up CL. For now, just replace runtime.GoSched with runtime.Gosched in the traces so we don't have a problem later if a test wants to look for that string. This change does regenerate the cmd/trace/v2 test, but it turns out the cmd/trace/v2 tests are way too strict about network unblock events, and 3 usually pop up instead of 1 or 2, which is what the test expects. AFAICT this looks plausible to me, so just lift the restriction on "up to 2" events entirely. Change-Id: Id7350132be19119c743c259f2f5250903bf41a04 Reviewed-on: https://go-review.googlesource.com/c/go/+/552275 TryBot-Bypass: Michael Knyszek <mknyszek@google.com> Reviewed-by: Michael Pratt <mpratt@google.com>
Diffstat (limited to 'src/runtime/trace2runtime.go')
-rw-r--r--src/runtime/trace2runtime.go2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/runtime/trace2runtime.go b/src/runtime/trace2runtime.go
index 9638e4b924..512e53907e 100644
--- a/src/runtime/trace2runtime.go
+++ b/src/runtime/trace2runtime.go
@@ -133,7 +133,7 @@ const (
var traceGoStopReasonStrings = [...]string{
traceGoStopGeneric: "unspecified",
- traceGoStopGoSched: "runtime.GoSched",
+ traceGoStopGoSched: "runtime.Gosched",
traceGoStopPreempted: "preempted",
}