diff options
| author | Dmitry Vyukov <dvyukov@google.com> | 2016-04-07 15:48:15 +0200 |
|---|---|---|
| committer | Dmitry Vyukov <dvyukov@google.com> | 2016-04-24 09:11:37 +0000 |
| commit | 75b844f0d228bda5dea2aabae096909f81355bac (patch) | |
| tree | f3751910ecac44a0ff89309efc03a8c520ce269e /src/runtime/trace/trace_stack_test.go | |
| parent | 687fe991e42f15fe1f491680c615ef96568f780a (diff) | |
| download | go-75b844f0d228bda5dea2aabae096909f81355bac.tar.xz | |
runtime/trace: test detection of broken timestamps
On some processors cputicks (used to generate trace timestamps)
produce non-monotonic timestamps. It is important that the parser
distinguishes logically inconsistent traces (e.g. missing, excessive
or misordered events) from broken timestamps. The former is a bug
in tracer, the latter is a machine issue.
Test that (1) parser does not return a logical error in case of
broken timestamps and (2) broken timestamps are eventually detected
and reported.
Change-Id: Ib4b1eb43ce128b268e754400ed8b5e8def04bd78
Reviewed-on: https://go-review.googlesource.com/21608
Reviewed-by: Austin Clements <austin@google.com>
Diffstat (limited to 'src/runtime/trace/trace_stack_test.go')
| -rw-r--r-- | src/runtime/trace/trace_stack_test.go | 5 |
1 files changed, 1 insertions, 4 deletions
diff --git a/src/runtime/trace/trace_stack_test.go b/src/runtime/trace/trace_stack_test.go index c3fb0f6fee..52a71bfb94 100644 --- a/src/runtime/trace/trace_stack_test.go +++ b/src/runtime/trace/trace_stack_test.go @@ -125,10 +125,7 @@ func TestTraceSymbolize(t *testing.T) { <-pipeReadDone Stop() - events, _, err := parseTrace(t, buf) - if err != nil { - t.Fatalf("failed to parse trace: %v", err) - } + events, _ := parseTrace(t, buf) // Now check that the stacks are correct. type frame struct { |