diff options
| author | Michael Anthony Knyszek <mknyszek@google.com> | 2020-07-23 20:17:40 +0000 |
|---|---|---|
| committer | Michael Knyszek <mknyszek@google.com> | 2020-10-26 17:25:47 +0000 |
| commit | 93d7d1685ee9e9f296e20f6c712796e54602e891 (patch) | |
| tree | 2014cedf247ccdf0e756cba61e72c461e71ab334 /src/runtime/trace.go | |
| parent | 8cc280aa727bc7159adfdd083861472aa3066a35 (diff) | |
| download | go-93d7d1685ee9e9f296e20f6c712796e54602e891.tar.xz | |
runtime: load gcControllerState.scanWork atomically in revise
gcControllerState.scanWork's docs state that it must be accessed
atomically during a GC cycle, but gcControllerState.revise does not do
this (even when called with the heap lock held).
This change makes it so that gcControllerState.revise accesses scanWork
atomically and explicitly.
Note that we don't update gcControllerState.revise's erroneous doc
comment here because this change isn't about revise's guarantees, just
about heap_scan. The comment is updated in a later change.
Change-Id: Iafc3ad214e517190bfd8a219896d23da19f7659d
Reviewed-on: https://go-review.googlesource.com/c/go/+/246961
Trust: Michael Knyszek <mknyszek@google.com>
Run-TryBot: Michael Knyszek <mknyszek@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Michael Pratt <mpratt@google.com>
Diffstat (limited to 'src/runtime/trace.go')
0 files changed, 0 insertions, 0 deletions