diff options
| author | Felix Geisendörfer <felix.geisendoerfer@datadoghq.com> | 2023-04-04 01:10:55 +0200 |
|---|---|---|
| committer | Quim Muntal <quimmuntal@gmail.com> | 2023-05-22 10:04:13 +0000 |
| commit | 3afbca5c5ff91b1b577b77cde6aecbfaac5881e5 (patch) | |
| tree | 621cb0af9014ee68d13afad4642b311ca054dc42 /src/runtime/trace.go | |
| parent | d75cc4b9c6e2acb4d0ed3d90c9a8b38094af281b (diff) | |
| download | go-3afbca5c5ff91b1b577b77cde6aecbfaac5881e5.tar.xz | |
runtime: rename getcallerfp to getfp
The previous name was wrong due to the mistaken assumption that calling
f->g->getcallerpc and f->g->getcallersp would respectively return the
pc/sp at g. However, they are actually referring to their caller's
caller, i.e. f.
Rename getcallerfp to getfp in order to stay consistent with this
naming convention.
Also see discussion on CL 463835.
For #16638
This is a redo of CL 481617 that became necessary because CL 461738
added another call site for getcallerfp().
Change-Id: If0b536e85a6c26061b65e7b5c2859fc31385d025
Reviewed-on: https://go-review.googlesource.com/c/go/+/494857
Reviewed-by: Michael Pratt <mpratt@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Cherry Mui <cherryyz@google.com>
Run-TryBot: Felix Geisendörfer <felix.geisendoerfer@datadoghq.com>
Diffstat (limited to 'src/runtime/trace.go')
| -rw-r--r-- | src/runtime/trace.go | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/runtime/trace.go b/src/runtime/trace.go index 378cd7bb08..2f9e141b09 100644 --- a/src/runtime/trace.go +++ b/src/runtime/trace.go @@ -970,7 +970,7 @@ func traceStackID(mp *m, pcBuf []uintptr, skip int) uint64 { // Fast path: Unwind using frame pointers. pcBuf[0] = uintptr(skip) if curgp == gp { - nstk += fpTracebackPCs(unsafe.Pointer(getcallerfp()), pcBuf[1:]) + nstk += fpTracebackPCs(unsafe.Pointer(getfp()), pcBuf[1:]) } else if curgp != nil { // We're called on the g0 stack through mcall(fn) or systemstack(fn). To // behave like gcallers above, we start unwinding from sched.bp, which |