diff options
| author | Austin Clements <austin@google.com> | 2017-10-16 20:28:29 -0400 |
|---|---|---|
| committer | Austin Clements <austin@google.com> | 2017-10-18 19:22:08 +0000 |
| commit | 193088b246f4bbe9a7d3a84ec7f4cc6786dac043 (patch) | |
| tree | 5798ac6c11085c6364b3af1120233b64a5c902da /src/runtime/sys_linux_386.s | |
| parent | 3ba818c894a1aa1e616a8531a1262d4f9d54f02a (diff) | |
| download | go-193088b246f4bbe9a7d3a84ec7f4cc6786dac043.tar.xz | |
runtime: separate error result for mmap
Currently mmap returns an unsafe.Pointer that encodes OS errors as
values less than 4096. In practice this is okay, but it borders on
being really unsafe: for example, the value has to be checked
immediately after return and if stack copying were ever to observe
such a value, it would panic. It's also not remotely idiomatic.
Fix this by making mmap return a separate pointer value and error,
like a normal Go function.
Updates #22218.
Change-Id: Iefd965095ffc82cc91118872753a5d39d785c3a6
Reviewed-on: https://go-review.googlesource.com/71270
Run-TryBot: Austin Clements <austin@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
Diffstat (limited to 'src/runtime/sys_linux_386.s')
| -rw-r--r-- | src/runtime/sys_linux_386.s | 9 |
1 files changed, 7 insertions, 2 deletions
diff --git a/src/runtime/sys_linux_386.s b/src/runtime/sys_linux_386.s index 722d2ab2d3..abed125f14 100644 --- a/src/runtime/sys_linux_386.s +++ b/src/runtime/sys_linux_386.s @@ -359,10 +359,15 @@ TEXT runtime·mmap(SB),NOSPLIT,$0 SHRL $12, BP INVOKE_SYSCALL CMPL AX, $0xfffff001 - JLS 3(PC) + JLS ok NOTL AX INCL AX - MOVL AX, ret+24(FP) + MOVL $0, p+24(FP) + MOVL AX, err+28(FP) + RET +ok: + MOVL AX, p+24(FP) + MOVL $0, err+28(FP) RET TEXT runtime·munmap(SB),NOSPLIT,$0 |