diff options
| author | Rick Hudson <rlh@golang.org> | 2016-02-08 09:53:14 -0500 |
|---|---|---|
| committer | Rick Hudson <rlh@golang.org> | 2016-04-27 21:54:39 +0000 |
| commit | aed861038f876643a67c2297b384b6be140c46c1 (patch) | |
| tree | cb90b6b6e28966a2aff61774dec59766c1edc5c7 /src/runtime/stack.go | |
| parent | 2ac8bdc52ae1ea0418df465de3f1ef36f49e2274 (diff) | |
| download | go-aed861038f876643a67c2297b384b6be140c46c1.tar.xz | |
[dev.garbage] runtime: add stackfreelist
The freelist for normal objects and the freelist
for stacks share the same mspan field for holding
the list head but are operated on by different code
sequences. This overloading complicates the use of bit
vectors for allocation of normal objects. This change
refactors the use of the stackfreelist out from the
use of freelist.
Change-Id: I5b155b5b8a1fcd8e24c12ee1eb0800ad9b6b4fa0
Reviewed-on: https://go-review.googlesource.com/19315
Reviewed-by: Austin Clements <austin@google.com>
Diffstat (limited to 'src/runtime/stack.go')
| -rw-r--r-- | src/runtime/stack.go | 23 |
1 files changed, 12 insertions, 11 deletions
diff --git a/src/runtime/stack.go b/src/runtime/stack.go index fdd6710bad..5e373f1b94 100644 --- a/src/runtime/stack.go +++ b/src/runtime/stack.go @@ -194,23 +194,23 @@ func stackpoolalloc(order uint8) gclinkptr { if s.ref != 0 { throw("bad ref") } - if s.freelist.ptr() != nil { - throw("bad freelist") + if s.stackfreelist.ptr() != nil { + throw("bad stackfreelist") } for i := uintptr(0); i < _StackCacheSize; i += _FixedStack << order { x := gclinkptr(uintptr(s.start)<<_PageShift + i) - x.ptr().next = s.freelist - s.freelist = x + x.ptr().next = s.stackfreelist + s.stackfreelist = x } list.insert(s) } - x := s.freelist + x := s.stackfreelist if x.ptr() == nil { throw("span has no free stacks") } - s.freelist = x.ptr().next + s.stackfreelist = x.ptr().next s.ref++ - if s.freelist.ptr() == nil { + if s.stackfreelist.ptr() == nil { // all stacks in s are allocated. list.remove(s) } @@ -223,12 +223,12 @@ func stackpoolfree(x gclinkptr, order uint8) { if s.state != _MSpanStack { throw("freeing stack not in a stack span") } - if s.freelist.ptr() == nil { + if s.stackfreelist.ptr() == nil { // s will now have a free stack stackpool[order].insert(s) } - x.ptr().next = s.freelist - s.freelist = x + x.ptr().next = s.stackfreelist + s.stackfreelist = x s.ref-- if gcphase == _GCoff && s.ref == 0 { // Span is completely free. Return it to the heap @@ -247,7 +247,7 @@ func stackpoolfree(x gclinkptr, order uint8) { // // By not freeing, we prevent step #4 until GC is done. stackpool[order].remove(s) - s.freelist = 0 + s.stackfreelist = 0 mheap_.freeStack(s) } } @@ -1138,6 +1138,7 @@ func freeStackSpans() { if s.ref == 0 { list.remove(s) s.freelist = 0 + s.stackfreelist = 0 mheap_.freeStack(s) } s = next |