diff options
| author | Keith Randall <khr@golang.org> | 2020-08-21 11:09:45 -0700 |
|---|---|---|
| committer | Keith Randall <khr@golang.org> | 2020-08-27 21:15:47 +0000 |
| commit | 5c2c6d3fbf4f0a1299b5e41463847d242eae19ca (patch) | |
| tree | 2db6e03226354716efb26a5233572841c429514f /src/runtime/stack.go | |
| parent | 29634436fd741a7c685bf8f242b6fd62f093d1ad (diff) | |
| download | go-5c2c6d3fbf4f0a1299b5e41463847d242eae19ca.tar.xz | |
runtime: framepointers are no longer an experiment - hard code them
I think they are no longer experimental status. Might as well promote
them to permanent.
Change-Id: Id1259601b3dd2061dd60df86ee48080bfb575d2f
Reviewed-on: https://go-review.googlesource.com/c/go/+/249857
Run-TryBot: Keith Randall <khr@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: David Chase <drchase@google.com>
Diffstat (limited to 'src/runtime/stack.go')
| -rw-r--r-- | src/runtime/stack.go | 6 |
1 files changed, 1 insertions, 5 deletions
diff --git a/src/runtime/stack.go b/src/runtime/stack.go index 0e930f60db..403b3c313e 100644 --- a/src/runtime/stack.go +++ b/src/runtime/stack.go @@ -648,12 +648,8 @@ func adjustframe(frame *stkframe, arg unsafe.Pointer) bool { } // Adjust saved base pointer if there is one. + // TODO what about arm64 frame pointer adjustment? if sys.ArchFamily == sys.AMD64 && frame.argp-frame.varp == 2*sys.RegSize { - if !framepointer_enabled { - print("runtime: found space for saved base pointer, but no framepointer experiment\n") - print("argp=", hex(frame.argp), " varp=", hex(frame.varp), "\n") - throw("bad frame layout") - } if stackDebug >= 3 { print(" saved bp\n") } |