diff options
| author | Russ Cox <rsc@golang.org> | 2024-05-21 23:24:47 -0400 |
|---|---|---|
| committer | Gopher Robot <gobot@golang.org> | 2024-05-23 00:18:55 +0000 |
| commit | bde905af5b11e3e34bc1f5d4846d7767f7197236 (patch) | |
| tree | 8def6eab2e681e1b463e8327279bc8f833b5f10f /src/runtime/slice.go | |
| parent | 2f07d4455636ece45ff843fe4d9298ea65f933c1 (diff) | |
| download | go-bde905af5b11e3e34bc1f5d4846d7767f7197236.tar.xz | |
all: document legacy //go:linkname for modules with ≥20,000 dependents
For #67401.
Change-Id: Icc10ede72547d8020c0ba45e89d954822a4b2455
Reviewed-on: https://go-review.googlesource.com/c/go/+/587218
Auto-Submit: Russ Cox <rsc@golang.org>
Reviewed-by: Cherry Mui <cherryyz@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Diffstat (limited to 'src/runtime/slice.go')
| -rw-r--r-- | src/runtime/slice.go | 10 |
1 files changed, 10 insertions, 0 deletions
diff --git a/src/runtime/slice.go b/src/runtime/slice.go index 3439a0d751..7ffca036c0 100644 --- a/src/runtime/slice.go +++ b/src/runtime/slice.go @@ -89,6 +89,15 @@ func makeslicecopy(et *_type, tolen int, fromlen int, from unsafe.Pointer) unsaf return to } +// makeslice should be an internal detail, +// but widely used packages access it using linkname. +// Notable members of the hall of shame include: +// - github.com/bytedance/sonic +// +// Do not remove or change the type signature. +// See go.dev/issue/67401. +// +//go:linkname makeslice func makeslice(et *_type, len, cap int) unsafe.Pointer { mem, overflow := math.MulUintptr(et.Size_, uintptr(cap)) if overflow || mem > maxAlloc || len < 0 || len > cap { @@ -156,6 +165,7 @@ func makeslice64(et *_type, len64, cap64 int64) unsafe.Pointer { // growslice should be an internal detail, // but widely used packages access it using linkname. // Notable members of the hall of shame include: +// - github.com/bytedance/sonic // - github.com/ugorji/go/codec // // Do not remove or change the type signature. |