diff options
| author | Damien Neil <dneil@google.com> | 2025-08-14 10:27:54 -0700 |
|---|---|---|
| committer | Gopher Robot <gobot@golang.org> | 2025-08-14 12:20:59 -0700 |
| commit | a8564bd412d4495a6048f981d30d4d7abb1e45a7 (patch) | |
| tree | aa69dbad941308b1b6817cd313d9746d3c9d3349 /src/runtime/select.go | |
| parent | 924fe98902cdebf20825ab5d1e4edfc0fed2966f (diff) | |
| download | go-a8564bd412d4495a6048f981d30d4d7abb1e45a7.tar.xz | |
runtime: make all synctest bubble violations fatal panics
Unblocking a bubbled goroutine from outside the bubble is an error
and panics. Currently, some of those panics are regular panics
and some are fatal. We use fatal panics in cases where its difficult
to panic without leaving something in an inconsistent state.
Change the regular panics (channel and timer operations) to be fatal.
This makes our behavior more consistent: All bubble violations are
always fatal.
More importantly, it avoids introducing new, recoverable panics.
A motivating example for this change is the context package,
which performs channel operations with a mutex held in the
expectation that those operations can never panic. These operations
can now panic as a result of a bubble violation, potentially
leaving a context.Context in an inconsistent state.
Fixes #74837
Change-Id: Ie6efd916b7f505c0f13dde42de1572992401f15c
Reviewed-on: https://go-review.googlesource.com/c/go/+/696195
Auto-Submit: Damien Neil <dneil@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Michael Pratt <mpratt@google.com>
Diffstat (limited to 'src/runtime/select.go')
| -rw-r--r-- | src/runtime/select.go | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/runtime/select.go b/src/runtime/select.go index ae7754b173..113dc8ad19 100644 --- a/src/runtime/select.go +++ b/src/runtime/select.go @@ -178,7 +178,7 @@ func selectgo(cas0 *scase, order0 *uint16, pc0 *uintptr, nsends, nrecvs int, blo if cas.c.bubble != nil { if getg().bubble != cas.c.bubble { - panic(plainError("select on synctest channel from outside bubble")) + fatal("select on synctest channel from outside bubble") } } else { allSynctest = false |