diff options
| author | Josh Bleecher Snyder <josharian@gmail.com> | 2017-08-23 06:58:47 -0700 |
|---|---|---|
| committer | Josh Bleecher Snyder <josharian@gmail.com> | 2017-08-24 05:07:40 +0000 |
| commit | 5df1fe52fe7b909c925738e516feb54be712f2c1 (patch) | |
| tree | c38dce7392bc9d7509dfda66ac7bc1c08d672b31 /src/runtime/runtime_test.go | |
| parent | 9d3d370632ef56c1966afc67b796fa950cb347c5 (diff) | |
| download | go-5df1fe52fe7b909c925738e516feb54be712f2c1.tar.xz | |
runtime: always rebuild in TestIntendedInlining
This is necessary when you aren't actively changing the runtime. Oops.
Also, run the tests on the builders, to avoid silent failures (#17472).
Change-Id: I1fc03790cdbddddb07026a772137a79919dcaac7
Reviewed-on: https://go-review.googlesource.com/58050
Run-TryBot: Josh Bleecher Snyder <josharian@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
Diffstat (limited to 'src/runtime/runtime_test.go')
| -rw-r--r-- | src/runtime/runtime_test.go | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/runtime/runtime_test.go b/src/runtime/runtime_test.go index 2355da9774..e1f1be7196 100644 --- a/src/runtime/runtime_test.go +++ b/src/runtime/runtime_test.go @@ -362,7 +362,7 @@ func TestVersion(t *testing.T) { // This allows refactoring for code clarity and re-use without fear that // changes to the compiler will cause silent performance regressions. func TestIntendedInlining(t *testing.T) { - if testing.Short() { + if testing.Short() && testenv.Builder() == "" { t.Skip("skipping in short mode") } testenv.MustHaveGoRun(t) @@ -376,7 +376,7 @@ func TestIntendedInlining(t *testing.T) { m[s] = true } - cmd := testEnv(exec.Command(testenv.GoToolPath(t), "build", "-gcflags=-m", "runtime")) + cmd := testEnv(exec.Command(testenv.GoToolPath(t), "build", "-a", "-gcflags=-m", "runtime")) out, err := cmd.CombinedOutput() if err != nil { t.Logf("%s", out) |