diff options
| author | Michael Anthony Knyszek <mknyszek@google.com> | 2025-06-27 00:59:49 +0000 |
|---|---|---|
| committer | Michael Knyszek <mknyszek@google.com> | 2025-06-27 10:59:23 -0700 |
| commit | 742fda95246958076e439bbcf71fedda43a894bb (patch) | |
| tree | 67370b38e66d647ea22f1959f231aaf15f328c82 /src/runtime/proc.go | |
| parent | fdc076ce762326fc19ef1b6de01da6ce50f55926 (diff) | |
| download | go-742fda95246958076e439bbcf71fedda43a894bb.tar.xz | |
runtime: account for missing frame pointer in preamble
If a goroutine is synchronously preempted, then taking a
frame-pointer-based stack trace at that preemption will skip PC of the
caller of the function which called into morestack. This happens because
the frame pointer is pushed to the stack after the preamble, leaving the
stack in an odd state for frame pointer unwinding.
Deal with this by marking a goroutine as synchronously preempted and
using that signal to load the missing PC from the stack. On LR platforms
this is available in gp.sched.lr. On non-LR platforms like x86, it's at
gp.sched.sp, because there are no args, no locals, and no frame pointer
pushed to the SP yet.
For #68090.
Change-Id: I73a1206d8b84eecb8a96dbe727195da30088f288
Reviewed-on: https://go-review.googlesource.com/c/go/+/684435
Reviewed-by: Cherry Mui <cherryyz@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Nick Ripley <nick.ripley@datadoghq.com>
Diffstat (limited to 'src/runtime/proc.go')
| -rw-r--r-- | src/runtime/proc.go | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/runtime/proc.go b/src/runtime/proc.go index 9817308430..0376f7812b 100644 --- a/src/runtime/proc.go +++ b/src/runtime/proc.go @@ -3307,10 +3307,10 @@ func execute(gp *g, inheritTime bool) { tryRecordGoroutineProfile(gp, nil, osyield) } - // Assign gp.m before entering _Grunning so running Gs have an - // M. + // Assign gp.m before entering _Grunning so running Gs have an M. mp.curg = gp gp.m = mp + gp.syncSafePoint = false // Clear the flag, which may have been set by morestack. casgstatus(gp, _Grunnable, _Grunning) gp.waitsince = 0 gp.preempt = false |