diff options
| author | Michael Pratt <mpratt@google.com> | 2022-03-04 13:24:04 -0500 |
|---|---|---|
| committer | Michael Pratt <mpratt@google.com> | 2022-04-28 16:50:31 +0000 |
| commit | 29bbca5c2c1ad41b2a9747890d183b6dd3a4ace4 (patch) | |
| tree | 74ea0c8d0bed2673984f9c0767c40ace72fc0bb2 /src/runtime/proc.go | |
| parent | 4bb45f7549548add8222aa4f3040d0e2120691a9 (diff) | |
| download | go-29bbca5c2c1ad41b2a9747890d183b6dd3a4ace4.tar.xz | |
runtime: differentiate "user" and "system" throws
"User" throws are throws due to some invariant broken by the application.
"System" throws are due to some invariant broken by the runtime,
environment, etc (i.e., not the fault of the application).
This CL sends "user" throws through the new fatal. Currently this
function is identical to throw, but with a different name to clearly
differentiate the throw type in the stack trace, and hopefully be a bit
more clear to users what it means.
This CL changes a few categories of throw to fatal:
1. Concurrent map read/write.
2. Deadlock detection.
3. Unlock of unlocked sync.Mutex.
4. Inconsistent results from syscall.AllThreadsSyscall.
"Thread exhaustion" and "out of memory" (usually address space full)
throws are additional throws that are arguably the fault of user code,
but I've left off for now because there is no specific invariant that
they have broken to get into these states.
For #51485
Change-Id: I713276a6c290fd34a6563e6e9ef378669d74ae32
Reviewed-on: https://go-review.googlesource.com/c/go/+/390420
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Austin Clements <austin@google.com>
Run-TryBot: Michael Pratt <mpratt@google.com>
Diffstat (limited to 'src/runtime/proc.go')
| -rw-r--r-- | src/runtime/proc.go | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/src/runtime/proc.go b/src/runtime/proc.go index b72194c76a..7ea3f9c56e 100644 --- a/src/runtime/proc.go +++ b/src/runtime/proc.go @@ -4089,7 +4089,7 @@ func newproc1(fn *funcval, callergp *g, callerpc uintptr) *g { if fn == nil { _g_.m.throwing = -1 // do not dump full stacks - throw("go of nil func value") + fatal("go of nil func value") } acquirem() // disable preemption because it can be holding p in a local var @@ -5012,7 +5012,7 @@ func checkdead() { }) if grunning == 0 { // possible if main goroutine calls runtime·Goexit() unlock(&sched.lock) // unlock so that GODEBUG=scheddetail=1 doesn't hang - throw("no goroutines (main called runtime.Goexit) - deadlock!") + fatal("no goroutines (main called runtime.Goexit) - deadlock!") } // Maybe jump time forward for playground. @@ -5047,7 +5047,7 @@ func checkdead() { getg().m.throwing = -1 // do not dump full stacks unlock(&sched.lock) // unlock so that GODEBUG=scheddetail=1 doesn't hang - throw("all goroutines are asleep - deadlock!") + fatal("all goroutines are asleep - deadlock!") } // forcegcperiod is the maximum time in nanoseconds between garbage |