diff options
| author | Damien Neil <dneil@google.com> | 2025-05-01 13:24:50 -0400 |
|---|---|---|
| committer | Gopher Robot <gobot@golang.org> | 2025-05-07 13:14:34 -0700 |
| commit | ef7724c4324f6bac40463a12e4fea43ff0b4a8e8 (patch) | |
| tree | 5a89783ddf1393124bee793515135012352f1e81 /src/runtime/panic.go | |
| parent | d6c8bedc7b3d2de7714dca75bd05912b371538f1 (diff) | |
| download | go-ef7724c4324f6bac40463a12e4fea43ff0b4a8e8.tar.xz | |
runtime: use "bubble" terminology for synctest
We've settled on calling the group of goroutines started by
synctest.Run a "bubble". At the time the runtime implementation
was written, I was still calling this a "group". Update the code
to match the current terminology.
Change-Id: I31b757f31d804b5d5f9564c182627030a9532f4a
Reviewed-on: https://go-review.googlesource.com/c/go/+/670135
Reviewed-by: Michael Pratt <mpratt@google.com>
Auto-Submit: Damien Neil <dneil@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Diffstat (limited to 'src/runtime/panic.go')
| -rw-r--r-- | src/runtime/panic.go | 14 |
1 files changed, 7 insertions, 7 deletions
diff --git a/src/runtime/panic.go b/src/runtime/panic.go index 706f9879dc..b8f23cc3c2 100644 --- a/src/runtime/panic.go +++ b/src/runtime/panic.go @@ -1312,12 +1312,12 @@ func fatalpanic(msgs *_panic) { // If this panic is the result of a synctest bubble deadlock, // print stacks for the goroutines in the bubble. - var sg *synctestGroup + var bubble *synctestBubble if de, ok := msgs.arg.(synctestDeadlockError); ok { - sg = de.sg + bubble = de.bubble } - docrash = dopanic_m(gp, pc, sp, sg) + docrash = dopanic_m(gp, pc, sp, bubble) }) if docrash { @@ -1399,8 +1399,8 @@ var deadlock mutex // gp is the crashing g running on this M, but may be a user G, while getg() is // always g0. -// If sg is non-nil, print the stacks for goroutines in this group as well. -func dopanic_m(gp *g, pc, sp uintptr, sg *synctestGroup) bool { +// If bubble is non-nil, print the stacks for goroutines in this group as well. +func dopanic_m(gp *g, pc, sp uintptr, bubble *synctestBubble) bool { if gp.sig != 0 { signame := signame(gp.sig) if signame != "" { @@ -1428,11 +1428,11 @@ func dopanic_m(gp *g, pc, sp uintptr, sg *synctestGroup) bool { if all { didothers = true tracebackothers(gp) - } else if sg != nil { + } else if bubble != nil { // This panic is caused by a synctest bubble deadlock. // Print stacks for goroutines in the deadlocked bubble. tracebacksomeothers(gp, func(other *g) bool { - return sg == other.syncGroup + return bubble == other.bubble }) } } |