diff options
| author | Ian Lance Taylor <iant@golang.org> | 2018-02-23 10:34:01 -0800 |
|---|---|---|
| committer | Ian Lance Taylor <iant@golang.org> | 2018-02-23 22:39:46 +0000 |
| commit | 804e3e565e98e1ff3a22eb354a473225f6dc7351 (patch) | |
| tree | 17140bfce6bd2ea40c967e9df4610b0a754b2fc3 /src/runtime/panic.go | |
| parent | a5e8e2d99815346cdff61905237056e0095c75ea (diff) | |
| download | go-804e3e565e98e1ff3a22eb354a473225f6dc7351.tar.xz | |
runtime: don't check for String/Error methods in printany
They have either already been called by preprintpanics, or they can
not be called safely because of the various conditions checked at the
start of gopanic.
Fixes #24059
Change-Id: I4a6233d12c9f7aaaee72f343257ea108bae79241
Reviewed-on: https://go-review.googlesource.com/96755
Reviewed-by: Austin Clements <austin@google.com>
Diffstat (limited to 'src/runtime/panic.go')
| -rw-r--r-- | src/runtime/panic.go | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/src/runtime/panic.go b/src/runtime/panic.go index 55ecb67654..dac63203fb 100644 --- a/src/runtime/panic.go +++ b/src/runtime/panic.go @@ -389,7 +389,6 @@ func Goexit() { // Call all Error and String methods before freezing the world. // Used when crashing with panicking. -// This must match types handled by printany. func preprintpanics(p *_panic) { defer func() { if recover() != nil { @@ -415,8 +414,6 @@ func printpanics(p *_panic) { print("\t") } print("panic: ") - // Because of preprintpanics, p.arg cannot be an error or - // stringer, so this won't call into user code. printany(p.arg) if p.recovered { print(" [recovered]") |