diff options
| author | Austin Clements <austin@google.com> | 2018-12-17 14:17:20 -0500 |
|---|---|---|
| committer | Austin Clements <austin@google.com> | 2018-12-17 21:24:06 +0000 |
| commit | 3c255e8bc6964ebee580b44835ddbe95c893e29f (patch) | |
| tree | 36a201966cbb0918fa2faa9f7ad5c5916a6dc180 /src/runtime/panic.go | |
| parent | 503091a77c43263a5ce86f9358de3445524627b7 (diff) | |
| download | go-3c255e8bc6964ebee580b44835ddbe95c893e29f.tar.xz | |
runtime: record extra information in throwOnGCWork crashes
Currently we only know the slot address and the value being written in
the throwOnGCWork crash tracebacks, and we have to infer the old value
from what's dumped by gcWork.checkPut. Sometimes these old values
don't make sense, like when we see a write of a nil pointer to a
freshly-allocated object, yet we observe marking a value (where did
that pointer come from?).
This CL adds the old value of the slot and the first two pointers in
the buffer to the traceback.
For #27993.
Change-Id: Ib70eead1afb9c06e8099e520172c3a2acaa45f80
Reviewed-on: https://go-review.googlesource.com/c/154597
Run-TryBot: Austin Clements <austin@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Michael Knyszek <mknyszek@google.com>
Diffstat (limited to 'src/runtime/panic.go')
0 files changed, 0 insertions, 0 deletions
