diff options
| author | Andy Pan <panjf2000@gmail.com> | 2022-07-25 12:32:24 +0800 |
|---|---|---|
| committer | Michael Knyszek <mknyszek@google.com> | 2022-08-09 13:23:50 +0000 |
| commit | ffe5f085cd8b289a7853fcdb3c26adbebda09fd6 (patch) | |
| tree | ef5c6a837de114e1aef48a4d655a1717ed0043a2 /src/runtime/netpoll_kqueue.go | |
| parent | 13bd6ddbe7a4fb24448546545da5df999267eb4e (diff) | |
| download | go-ffe5f085cd8b289a7853fcdb3c26adbebda09fd6.tar.xz | |
runtime: refine code reducing indents in netpollBreak()
Change-Id: I2d1528910cb3660344c7a664d6f32306defe75d3
Reviewed-on: https://go-review.googlesource.com/c/go/+/419321
Reviewed-by: Michael Pratt <mpratt@google.com>
Auto-Submit: Michael Knyszek <mknyszek@google.com>
Reviewed-by: Michael Knyszek <mknyszek@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Michael Pratt <mpratt@google.com>
Diffstat (limited to 'src/runtime/netpoll_kqueue.go')
| -rw-r--r-- | src/runtime/netpoll_kqueue.go | 27 |
1 files changed, 15 insertions, 12 deletions
diff --git a/src/runtime/netpoll_kqueue.go b/src/runtime/netpoll_kqueue.go index 1694753b6f..78d1663ad9 100644 --- a/src/runtime/netpoll_kqueue.go +++ b/src/runtime/netpoll_kqueue.go @@ -83,19 +83,22 @@ func netpollarm(pd *pollDesc, mode int) { // netpollBreak interrupts a kevent. func netpollBreak() { - if atomic.Cas(&netpollWakeSig, 0, 1) { - for { - var b byte - n := write(netpollBreakWr, unsafe.Pointer(&b), 1) - if n == 1 || n == -_EAGAIN { - break - } - if n == -_EINTR { - continue - } - println("runtime: netpollBreak write failed with", -n) - throw("runtime: netpollBreak write failed") + // Failing to cas indicates there is an in-flight wakeup, so we're done here. + if !atomic.Cas(&netpollWakeSig, 0, 1) { + return + } + + for { + var b byte + n := write(netpollBreakWr, unsafe.Pointer(&b), 1) + if n == 1 || n == -_EAGAIN { + break + } + if n == -_EINTR { + continue } + println("runtime: netpollBreak write failed with", -n) + throw("runtime: netpollBreak write failed") } } |
