diff options
| author | Cuong Manh Le <cuong.manhle.vn@gmail.com> | 2024-03-07 14:49:30 +0700 |
|---|---|---|
| committer | Gopher Robot <gobot@golang.org> | 2024-03-08 02:00:33 +0000 |
| commit | 5a329c3bfb6328a66812e21bd1a5a32f8a5c76b0 (patch) | |
| tree | 887921d1bd903fafdde40d893d0d3f2ba8416acd /src/runtime/mpallocbits.go | |
| parent | 8590f0aef30d1e4d242af97ae15266facb26493b (diff) | |
| download | go-5a329c3bfb6328a66812e21bd1a5a32f8a5c76b0.tar.xz | |
cmd/compile: fix copying SSA-able variables optimization
CL 541715 added an optimization to copy SSA-able variables.
When handling m[k] = append(m[k], ...) case, it uses ir.SameSafeExpr to
check that m[k] expressions are the same, then doing type assertion to
convert the map index to ir.IndexExpr node. However, this assertion is
not safe for m[k] expression in append(m[k], ...), since it may be
wrapped by ir.OCONVNOP node.
Fixing this by un-wrapping any ir.OCONVNOP before doing type assertion.
Fixes #66096
Change-Id: I9ff7165ab97bc7f88d0e9b7b31604da19a8ca206
Reviewed-on: https://go-review.googlesource.com/c/go/+/569716
Auto-Submit: Cuong Manh Le <cuong.manhle.vn@gmail.com>
Reviewed-by: Matthew Dempsky <mdempsky@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Michael Knyszek <mknyszek@google.com>
Diffstat (limited to 'src/runtime/mpallocbits.go')
0 files changed, 0 insertions, 0 deletions