diff options
| author | Keith Randall <khr@golang.org> | 2024-01-11 12:52:16 -0800 |
|---|---|---|
| committer | Gopher Robot <gobot@golang.org> | 2024-01-11 21:16:56 +0000 |
| commit | 0f3876f8c12ba3746a1dfec68422e9cce5c2ff39 (patch) | |
| tree | eb278463dd6e8c0ade8739382286fde0576582ba /src/runtime/mbitmap_allocheaders.go | |
| parent | 25c5f6f15988f1abb9738bfdfd10331afefd8ec1 (diff) | |
| download | go-0f3876f8c12ba3746a1dfec68422e9cce5c2ff39.tar.xz | |
runtime: ensure we free unrolled GC bitmaps
CL 555355 has a bug in it - the GC program flag was also used to decide
when to free the unrolled bitmap. After that CL, we just don't free any
unrolled bitmaps, leading to a memory leak.
Use a separate flag to track types that need to be freed when their
corresponding object is freed.
Change-Id: I841b65492561f5b5e1853875fbd8e8a872205a84
Reviewed-on: https://go-review.googlesource.com/c/go/+/555416
Auto-Submit: Keith Randall <khr@google.com>
Reviewed-by: Michael Knyszek <mknyszek@google.com>
Reviewed-by: Keith Randall <khr@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Diffstat (limited to 'src/runtime/mbitmap_allocheaders.go')
| -rw-r--r-- | src/runtime/mbitmap_allocheaders.go | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/src/runtime/mbitmap_allocheaders.go b/src/runtime/mbitmap_allocheaders.go index bc574ad689..1ec055352e 100644 --- a/src/runtime/mbitmap_allocheaders.go +++ b/src/runtime/mbitmap_allocheaders.go @@ -886,6 +886,7 @@ func heapSetType(x, dataSize uintptr, typ *_type, header **_type, span *mspan) ( gctyp.Size_ = typ.Size_ gctyp.PtrBytes = typ.PtrBytes gctyp.GCData = (*byte)(add(unsafe.Pointer(progSpan.base()), heapBitsOff)) + gctyp.TFlag = abi.TFlagUnrolledBitmap // Expand the GC program into space reserved at the end of the new span. runGCProg(addb(typ.GCData, 4), gctyp.GCData) |