aboutsummaryrefslogtreecommitdiff
path: root/src/runtime/mbitmap_allocheaders.go
diff options
context:
space:
mode:
authorBryan C. Mills <bcmills@google.com>2023-11-16 17:03:06 -0500
committerGopher Robot <gobot@golang.org>2023-11-17 22:43:50 +0000
commit0b90c7d4453bb21ec3ad4d6c5a3eebf398a89e77 (patch)
tree13e225d49c5a9accee86b02157b175266b6f48c6 /src/runtime/mbitmap_allocheaders.go
parentbb8a96fa547985168241eea72ee2bec15e749eff (diff)
downloadgo-0b90c7d4453bb21ec3ad4d6c5a3eebf398a89e77.tar.xz
cmd/go: use a nil *Origin to represent "uncheckable"
Previously, we used the presence of individual origin fields to decide whether an Origin could be checked for staleness, with a nil Origin representing “use whatever you have”. However, that turns out to be fairly bug-prone: if we forget to populate an Origin somewhere, we end up with an incomplete check instead of a non-reusable origin (see #61415, #61423). As of CL 543155, the reusability check for a given query now depends on what is needed by the query more than what is populated in the origin. With that in place, we can simplify the handling of the Origin struct by using a nil pointer to represent inconsistent or unavailable origin data, and otherwise always reporting whatever origin information we have regardless of whether we expect it to be reused. Updates #61415. Updates #61423. Change-Id: I97c51063d6c2afa394a05bf304a80c72c08f82cf Cq-Include-Trybots: luci.golang.try:gotip-linux-amd64-longtest,gotip-windows-amd64-longtest Reviewed-on: https://go-review.googlesource.com/c/go/+/543216 Auto-Submit: Bryan Mills <bcmills@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Michael Matloob <matloob@golang.org>
Diffstat (limited to 'src/runtime/mbitmap_allocheaders.go')
0 files changed, 0 insertions, 0 deletions