diff options
| author | Russ Cox <rsc@golang.org> | 2024-05-21 23:02:51 -0400 |
|---|---|---|
| committer | Gopher Robot <gobot@golang.org> | 2024-05-22 21:17:41 +0000 |
| commit | 5fee159bc2e60736ce967560ee5be738fe5d5bd2 (patch) | |
| tree | e6ebbad97d446072a6d06b3c5f8a5748b7014b96 /src/runtime/malloc.go | |
| parent | 4c589d93ad6f77e31cccc237c20133f0d8d8492f (diff) | |
| download | go-5fee159bc2e60736ce967560ee5be738fe5d5bd2.tar.xz | |
all: document legacy //go:linkname for modules with ≥50,000 dependents
Note that this depends on the revert of CL 581395 to move zeroVal back.
For #67401.
Change-Id: I507c27c2404ad1348aabf1ffa3740e6b1957495b
Reviewed-on: https://go-review.googlesource.com/c/go/+/587217
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Auto-Submit: Russ Cox <rsc@golang.org>
Reviewed-by: Cherry Mui <cherryyz@google.com>
Diffstat (limited to 'src/runtime/malloc.go')
| -rw-r--r-- | src/runtime/malloc.go | 22 |
1 files changed, 22 insertions, 0 deletions
diff --git a/src/runtime/malloc.go b/src/runtime/malloc.go index 4034060424..0e43b7acf4 100644 --- a/src/runtime/malloc.go +++ b/src/runtime/malloc.go @@ -965,6 +965,16 @@ func (c *mcache) nextFree(spc spanClass) (v gclinkptr, s *mspan, shouldhelpgc bo // Allocate an object of size bytes. // Small objects are allocated from the per-P cache's free lists. // Large objects (> 32 kB) are allocated straight from the heap. +// +// mallocgc should be an internal detail, +// but widely used packages access it using linkname. +// Notable members of the hall of shame include: +// - github.com/ugorji/go/codec +// +// Do not remove or change the type signature. +// See go.dev/issue/67401. +// +//go:linkname mallocgc func mallocgc(size uintptr, typ *_type, needzero bool) unsafe.Pointer { if gcphase == _GCmarktermination { throw("mallocgc called with gcphase == _GCmarktermination") @@ -1374,6 +1384,7 @@ func newobject(typ *_type) unsafe.Pointer { // reflect_unsafe_New is meant for package reflect, // but widely used packages access it using linkname. // Notable members of the hall of shame include: +// - github.com/goccy/json // - github.com/modern-go/reflect2 // // Do not remove or change the type signature. @@ -1390,6 +1401,16 @@ func reflectlite_unsafe_New(typ *_type) unsafe.Pointer { } // newarray allocates an array of n elements of type typ. +// +// newarray should be an internal detail, +// but widely used packages access it using linkname. +// Notable members of the hall of shame include: +// - github.com/ugorji/go/codec +// +// Do not remove or change the type signature. +// See go.dev/issue/67401. +// +//go:linkname newarray func newarray(typ *_type, n int) unsafe.Pointer { if n == 1 { return mallocgc(typ.Size_, typ, true) @@ -1404,6 +1425,7 @@ func newarray(typ *_type, n int) unsafe.Pointer { // reflect_unsafe_NewArray is meant for package reflect, // but widely used packages access it using linkname. // Notable members of the hall of shame include: +// - github.com/goccy/json // - github.com/modern-go/reflect2 // // Do not remove or change the type signature. |