diff options
| author | Michael Pratt <mpratt@google.com> | 2026-03-20 17:50:07 -0400 |
|---|---|---|
| committer | Keith Randall <khr@golang.org> | 2026-03-20 18:35:35 -0700 |
| commit | 5f5f4ccdb385fa73de5729cfe8c0336b44a88f4c (patch) | |
| tree | 712adbd438c58e8a483227ce52725a4b9ef902e0 /src/runtime/malloc.go | |
| parent | 16018b05ae226e7a99f166bded7f939c5b0c4a98 (diff) | |
| download | go-5f5f4ccdb385fa73de5729cfe8c0336b44a88f4c.tar.xz | |
Revert "runtime, cmd/compile: use preemptible memclr for large pointer-free clears"
This reverts CL 750480.
Reason: Adding preemptible memclrNoHeapPointers exposes existing unsafe
use of notInHeapSlice, causing crashes. Revert the memclr stack until
the underlying issue is fixed.
We keep the test added in CL 755942, which is useful regardless.
For #78254.
Change-Id: I8be3f9a20292b7f294e98e74e5a86c6a204406ae
Reviewed-on: https://go-review.googlesource.com/c/go/+/757343
Reviewed-by: Keith Randall <khr@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Keith Randall <khr@golang.org>
Diffstat (limited to 'src/runtime/malloc.go')
| -rw-r--r-- | src/runtime/malloc.go | 9 |
1 files changed, 0 insertions, 9 deletions
diff --git a/src/runtime/malloc.go b/src/runtime/malloc.go index 2144ea602a..c08bc7574b 100644 --- a/src/runtime/malloc.go +++ b/src/runtime/malloc.go @@ -2202,15 +2202,6 @@ func memclrNoHeapPointersChunked(size uintptr, x unsafe.Pointer) { } } -// memclrNoHeapPointersPreemptible is the compiler-callable entry point -// for clearing large buffers with preemption support. It has the same -// signature as memclrNoHeapPointers so the compiler can emit calls to it -// directly. It delegates to memclrNoHeapPointersChunked which splits the -// work into 256KB chunks with preemption checks between them. -func memclrNoHeapPointersPreemptible(ptr unsafe.Pointer, n uintptr) { - memclrNoHeapPointersChunked(n, ptr) -} - // implementation of new builtin // compiler (both frontend and SSA backend) knows the signature // of this function. |
