diff options
| author | Austin Clements <austin@google.com> | 2014-11-19 11:30:58 -0500 |
|---|---|---|
| committer | Austin Clements <austin@google.com> | 2014-11-19 11:30:58 -0500 |
| commit | b76e836042dd65b39cfe7af0f8ff5f73f12142a2 (patch) | |
| tree | 56bee4a6465ced192cb030cd2ea538c5d0759248 /src/runtime/lfstack.go | |
| parent | b27c0618eb468d9ac322a65bd40db6e829694907 (diff) | |
| download | go-b76e836042dd65b39cfe7af0f8ff5f73f12142a2.tar.xz | |
[dev.cc] runtime: allow more address bits in lfstack on Power64
Previously, lfstack assumed Linux limited user space addresses
to 43 bits on Power64 based on a paper from 2001. It turns
out the limit is now 46 bits, so lfstack was truncating
pointers.
Raise the limit to 48 bits (for some future proofing and to
make it match amd64) and add a self-test that will fail in a
useful way if ever unpack(pack(x)) != x.
With this change, dev.cc passes all.bash on power64le.
LGTM=rsc
R=rsc
CC=golang-codereviews
https://golang.org/cl/174430043
Diffstat (limited to 'src/runtime/lfstack.go')
| -rw-r--r-- | src/runtime/lfstack.go | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/src/runtime/lfstack.go b/src/runtime/lfstack.go index 4a20fff9d8..8a36a67b35 100644 --- a/src/runtime/lfstack.go +++ b/src/runtime/lfstack.go @@ -12,6 +12,10 @@ import "unsafe" func lfstackpush(head *uint64, node *lfnode) { node.pushcnt++ new := lfstackPack(node, node.pushcnt) + if node1, _ := lfstackUnpack(new); node1 != node { + println("runtime: lfstackpush invalid packing: node=", node, " cnt=", hex(node.pushcnt), " packed=", hex(new), " -> node=", node1, "\n") + gothrow("lfstackpush") + } for { old := atomicload64(head) node.next, _ = lfstackUnpack(old) |