diff options
| author | Austin Clements <austin@google.com> | 2018-04-25 16:53:04 -0400 |
|---|---|---|
| committer | Austin Clements <austin@google.com> | 2018-04-29 00:03:04 +0000 |
| commit | 0fd427fda70d635a526efc8cf40251718e5a45bf (patch) | |
| tree | 20658392a3c324f27070274a9499e82697b35f4b /src/runtime/heapdump.go | |
| parent | 3c65bb5b90e0ea367775d4c51966260b1e7c4d25 (diff) | |
| download | go-0fd427fda70d635a526efc8cf40251718e5a45bf.tar.xz | |
runtime: use entry stack map at function entry
Currently, when the runtime looks up the stack map for a frame, it
uses frame.continpc - 1 unless continpc is the function entry PC, in
which case it uses frame.continpc. As a result, if continpc is the
function entry point (which happens for deferred frames), it will
actually look up the stack map *following* the first instruction.
I think, though I am not positive, that this is always okay today
because the first instruction of a function can never change the stack
map. It's usually not a CALL, so it doesn't have PCDATA. Or, if it is
a CALL, it has to have the entry stack map.
But we're about to start emitting stack maps at every instruction that
changes them, which means the first instruction can have PCDATA
(notably, in leaf functions that don't have a prologue).
To prepare for this, tweak how the runtime looks up stack map indexes
so that if continpc is the function entry point, it directly uses the
entry stack map.
For #24543.
Change-Id: I85aa818041cd26aff416f7b1fba186e9c8ca6568
Reviewed-on: https://go-review.googlesource.com/109349
Reviewed-by: Rick Hudson <rlh@golang.org>
Diffstat (limited to 'src/runtime/heapdump.go')
| -rw-r--r-- | src/runtime/heapdump.go | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/src/runtime/heapdump.go b/src/runtime/heapdump.go index b255cbbae3..2b8937834c 100644 --- a/src/runtime/heapdump.go +++ b/src/runtime/heapdump.go @@ -248,10 +248,11 @@ func dumpframe(s *stkframe, arg unsafe.Pointer) bool { // Figure out what we can about our stack map pc := s.pc + pcdata := int32(-1) // Use the entry map at function entry if pc != f.entry { pc-- + pcdata = pcdatavalue(f, _PCDATA_StackMapIndex, pc, nil) } - pcdata := pcdatavalue(f, _PCDATA_StackMapIndex, pc, nil) if pcdata == -1 { // We do not have a valid pcdata value but there might be a // stackmap for this function. It is likely that we are looking |