diff options
| author | Keith Randall <khr@golang.org> | 2021-08-28 15:50:52 -0700 |
|---|---|---|
| committer | Keith Randall <khr@google.com> | 2022-05-12 22:32:42 +0000 |
| commit | 016d7552138077741a9c3fdadc73c0179f5d3ff7 (patch) | |
| tree | cfe978bcbb00bb7e67a610af16fe5706cd181723 /src/runtime/export_test.go | |
| parent | da0a6f4b57fc9eb4779c295bc9620c5ed271a641 (diff) | |
| download | go-016d7552138077741a9c3fdadc73c0179f5d3ff7.tar.xz | |
runtime: measure stack usage; start stacks larger if needed
Measure the average stack size used by goroutines at every GC. When
starting a new goroutine, allocate an initial goroutine stack of that
average size. Intuition is that we'll waste at most 2x in stack space
because only half the goroutines can be below average. In turn, we
avoid some of the early stack growth / copying needed in the average
case.
More details in the design doc at: https://docs.google.com/document/d/1YDlGIdVTPnmUiTAavlZxBI1d9pwGQgZT7IKFKlIXohQ/edit?usp=sharing
name old time/op new time/op delta
Issue18138 95.3µs ± 0% 67.3µs ±13% -29.35% (p=0.000 n=9+10)
Fixes #18138
Change-Id: Iba34d22ed04279da7e718bbd569bbf2734922eaa
Reviewed-on: https://go-review.googlesource.com/c/go/+/345889
Run-TryBot: Keith Randall <khr@golang.org>
Reviewed-by: Michael Knyszek <mknyszek@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Keith Randall <khr@google.com>
Diffstat (limited to 'src/runtime/export_test.go')
| -rw-r--r-- | src/runtime/export_test.go | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/runtime/export_test.go b/src/runtime/export_test.go index 380bf9cb13..230ed76c81 100644 --- a/src/runtime/export_test.go +++ b/src/runtime/export_test.go @@ -1294,7 +1294,7 @@ func (c *GCController) StartCycle(stackSize, globalsSize uint64, scannableFrac f if c.heapMarked > trigger { trigger = c.heapMarked } - c.scannableStackSize = stackSize + c.maxStackScan = stackSize c.globalsScan = globalsSize c.heapLive = trigger c.heapScan += uint64(float64(trigger-c.heapMarked) * scannableFrac) |