diff options
| author | Brad Fitzpatrick <bradfitz@golang.org> | 2016-12-06 19:55:10 +0000 |
|---|---|---|
| committer | Brad Fitzpatrick <bradfitz@golang.org> | 2017-02-10 18:28:37 +0000 |
| commit | 9f75ecd5e12f2b9988086954933d610cd5647918 (patch) | |
| tree | d153c617a00e0eb18eddba3e5bdc5476e183873d /src/runtime/debug | |
| parent | 2a74b9e81405e34c67880866552b5d7bcab74de1 (diff) | |
| download | go-9f75ecd5e12f2b9988086954933d610cd5647918.tar.xz | |
runtime/debug: don't run a GC when setting SetGCPercent negative
If the user is calling SetGCPercent(-1), they intend to disable GC.
They probably don't intend to run one. If they do, they can call
runtime.GC themselves.
Change-Id: I40ef40dfc7e15193df9ff26159cd30e56b666f73
Reviewed-on: https://go-review.googlesource.com/34013
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Austin Clements <austin@google.com>
Diffstat (limited to 'src/runtime/debug')
| -rw-r--r-- | src/runtime/debug/garbage.go | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/src/runtime/debug/garbage.go b/src/runtime/debug/garbage.go index c82c024235..27adc70fd3 100644 --- a/src/runtime/debug/garbage.go +++ b/src/runtime/debug/garbage.go @@ -90,7 +90,9 @@ func ReadGCStats(stats *GCStats) { // A negative percentage disables garbage collection. func SetGCPercent(percent int) int { old := setGCPercent(int32(percent)) - runtime.GC() + if percent >= 0 { + runtime.GC() + } return int(old) } |