diff options
| author | qmuntal <quimmuntal@gmail.com> | 2025-02-24 09:43:41 +0100 |
|---|---|---|
| committer | Quim Muntal <quimmuntal@gmail.com> | 2025-02-24 11:03:10 -0800 |
| commit | dceee2e983f5dab65c3905ecf40e70e15cf41b7d (patch) | |
| tree | 90d8aec778115127028196a5de6b321008252b92 /src/runtime/debug/stack_test.go | |
| parent | 2ee775fd9b58247618cf8bc06935f33875bdc872 (diff) | |
| download | go-dceee2e983f5dab65c3905ecf40e70e15cf41b7d.tar.xz | |
all: use testenv.Executable instead of os.Executable and os.Args[0]
In test files, using testenv.Executable is more reliable than
os.Executable or os.Args[0].
Change-Id: I88e577efeabc20d02ada27bf706ae4523129128e
Reviewed-on: https://go-review.googlesource.com/c/go/+/651955
Reviewed-by: Cherry Mui <cherryyz@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Ian Lance Taylor <iant@google.com>
Diffstat (limited to 'src/runtime/debug/stack_test.go')
| -rw-r--r-- | src/runtime/debug/stack_test.go | 17 |
1 files changed, 3 insertions, 14 deletions
diff --git a/src/runtime/debug/stack_test.go b/src/runtime/debug/stack_test.go index e1559303f0..88d4ad0c0f 100644 --- a/src/runtime/debug/stack_test.go +++ b/src/runtime/debug/stack_test.go @@ -87,12 +87,7 @@ func TestStack(t *testing.T) { // initial (not current) environment. Spawn a subprocess to determine the // real baked-in GOROOT. t.Logf("found GOROOT %q from environment; checking embedded GOROOT value", envGoroot) - testenv.MustHaveExec(t) - exe, err := os.Executable() - if err != nil { - t.Fatal(err) - } - cmd := exec.Command(exe) + cmd := exec.Command(testenv.Executable(t)) cmd.Env = append(os.Environ(), "GOROOT=", "GO_RUNTIME_DEBUG_TEST_ENTRYPOINT=dumpgoroot") out, err := cmd.Output() if err != nil { @@ -137,18 +132,12 @@ func TestStack(t *testing.T) { } func TestSetCrashOutput(t *testing.T) { - testenv.MustHaveExec(t) - exe, err := os.Executable() - if err != nil { - t.Fatal(err) - } - crashOutput := filepath.Join(t.TempDir(), "crash.out") - cmd := exec.Command(exe) + cmd := exec.Command(testenv.Executable(t)) cmd.Stderr = new(strings.Builder) cmd.Env = append(os.Environ(), "GO_RUNTIME_DEBUG_TEST_ENTRYPOINT=setcrashoutput", "CRASHOUTPUT="+crashOutput) - err = cmd.Run() + err := cmd.Run() stderr := fmt.Sprint(cmd.Stderr) if err == nil { t.Fatalf("child process succeeded unexpectedly (stderr: %s)", stderr) |