diff options
| author | Paschalis Tsilias <paschalis.tsilias@gmail.com> | 2020-09-18 19:15:41 +0300 |
|---|---|---|
| committer | Giovanni Bajo <rasky@develer.com> | 2020-09-20 09:54:44 +0000 |
| commit | 331614c4daa5504ddfe35a96371cc34783d14cf1 (patch) | |
| tree | ef3eab158a8ae1b62cc860a1710e42fbcb81de1c /src/runtime/debug/garbage.go | |
| parent | a3868028ac8470d1ab7782614707bb90925e7fe3 (diff) | |
| download | go-331614c4daa5504ddfe35a96371cc34783d14cf1.tar.xz | |
runtime: improve error messages after allocating a stack that is too big
In the current implementation, we can observe crashes after calling
debug.SetMaxStack and allocating a stack larger than 4GB since
stackalloc works with 32-bit sizes. To avoid this, we define an upper
limit as the largest feasible point we can grow a stack to and provide a
better error message when we get a stack overflow.
Fixes #41228
Change-Id: I55fb0a824f47ed9fb1fcc2445a4dfd57da9ef8d4
Reviewed-on: https://go-review.googlesource.com/c/go/+/255997
Run-TryBot: Keith Randall <khr@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Trust: Giovanni Bajo <rasky@develer.com>
Reviewed-by: Keith Randall <khr@golang.org>
Diffstat (limited to 'src/runtime/debug/garbage.go')
| -rw-r--r-- | src/runtime/debug/garbage.go | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/src/runtime/debug/garbage.go b/src/runtime/debug/garbage.go index e36e54f12d..00f92c3ddf 100644 --- a/src/runtime/debug/garbage.go +++ b/src/runtime/debug/garbage.go @@ -106,6 +106,8 @@ func FreeOSMemory() { // the program crashes. // SetMaxStack returns the previous setting. // The initial setting is 1 GB on 64-bit systems, 250 MB on 32-bit systems. +// There may be a system-imposed maximum stack limit regardless +// of the value provided to SetMaxStack. // // SetMaxStack is useful mainly for limiting the damage done by // goroutines that enter an infinite recursion. It only limits future |