diff options
| author | Alan Donovan <adonovan@google.com> | 2024-04-23 12:44:54 -0400 |
|---|---|---|
| committer | Gopher Robot <gobot@golang.org> | 2024-05-08 19:10:41 +0000 |
| commit | 69e75c8581e15328454bb6e2f1dc347f73616b37 (patch) | |
| tree | f0fabe495e978fb211ef909e4c4b8d8a4085d559 /src/runtime/crash_test.go | |
| parent | 4513f1a1c1037574bfd94b8637329246f475a534 (diff) | |
| download | go-69e75c8581e15328454bb6e2f1dc347f73616b37.tar.xz | |
runtime: properly frame panic values in tracebacks
This CL causes the printing of panic values to ensure that all
newlines in the output are immediately followed by a tab, so
that there is no way for a maliciously crafted panic value to
fool a program attempting to parse the traceback into thinking
that the panic value is in fact a goroutine stack.
See https://github.com/golang/go/issues/64590#issuecomment-1932675696
+ release note
Updates #64590
Updates #63455
Change-Id: I5142acb777383c0c122779d984e73879567dc627
Reviewed-on: https://go-review.googlesource.com/c/go/+/581215
Auto-Submit: Alan Donovan <adonovan@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Michael Pratt <mpratt@google.com>
Diffstat (limited to 'src/runtime/crash_test.go')
| -rw-r--r-- | src/runtime/crash_test.go | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/src/runtime/crash_test.go b/src/runtime/crash_test.go index 19c9cddf36..9a5fa61588 100644 --- a/src/runtime/crash_test.go +++ b/src/runtime/crash_test.go @@ -966,11 +966,11 @@ func TestPanicWhilePanicking(t *testing.T) { Func string }{ { - "panic while printing panic value: important error message", + "panic while printing panic value: important multi-line\n\terror message", "ErrorPanic", }, { - "panic while printing panic value: important stringer message", + "panic while printing panic value: important multi-line\n\tstringer message", "StringerPanic", }, { @@ -986,7 +986,7 @@ func TestPanicWhilePanicking(t *testing.T) { "CircularPanic", }, { - "important string message", + "important multi-line\n\tstring message", "StringPanic", }, { |