diff options
| author | Russ Cox <rsc@golang.org> | 2024-03-14 15:30:13 -0400 |
|---|---|---|
| committer | Gopher Robot <gobot@golang.org> | 2024-03-14 20:20:55 +0000 |
| commit | 386dcf4c93bfc8af232a12086d73da4bb3558af9 (patch) | |
| tree | ec3b78531f10f9f51d248ed0547265b0bb649b6f /src/runtime/crash_test.go | |
| parent | 966609ad9e82ba173bcc8f57f4bfc35a86a62c8a (diff) | |
| download | go-386dcf4c93bfc8af232a12086d73da4bb3558af9.tar.xz | |
runtime: revert "traceback: include pc=0x%x for inline frames"
This reverts commit 643d816c8b43 (CL 561635).
Reason for revert: This works for telemetry but broke various other
properties of the tracebacks as well as some programs that read
tracebacks. We should figure out a solution that works for all uses,
and in the interim we should not be making telemetry work at the
cost of breaking other, existing valid uses.
See #65761 for details.
Change-Id: I467993ae778887e5bd3cca4c0fb54e9d44802ee1
Reviewed-on: https://go-review.googlesource.com/c/go/+/571797
Auto-Submit: Russ Cox <rsc@golang.org>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Austin Clements <austin@google.com>
Reviewed-by: Cherry Mui <cherryyz@google.com>
Diffstat (limited to 'src/runtime/crash_test.go')
| -rw-r--r-- | src/runtime/crash_test.go | 13 |
1 files changed, 0 insertions, 13 deletions
diff --git a/src/runtime/crash_test.go b/src/runtime/crash_test.go index 9ba45b8f2a..33edb4652b 100644 --- a/src/runtime/crash_test.go +++ b/src/runtime/crash_test.go @@ -14,7 +14,6 @@ import ( "internal/testenv" tracev2 "internal/trace/v2" "io" - "log" "os" "os/exec" "path/filepath" @@ -29,19 +28,7 @@ import ( var toRemove []string -const entrypointVar = "RUNTIME_TEST_ENTRYPOINT" - func TestMain(m *testing.M) { - switch entrypoint := os.Getenv(entrypointVar); entrypoint { - case "crash": - crash() - panic("unreachable") - default: - log.Fatalf("invalid %s: %q", entrypointVar, entrypoint) - case "": - // fall through to normal behavior - } - _, coreErrBefore := os.Stat("core") status := m.Run() |