diff options
| author | Than McIntosh <thanm@google.com> | 2023-05-03 13:40:02 -0400 |
|---|---|---|
| committer | Gopher Robot <gobot@golang.org> | 2023-05-03 20:32:34 +0000 |
| commit | 91a716a043f01334e7e6d28af4863d2188ffb336 (patch) | |
| tree | 63e5bb373c6de0074ab8d95d0744af97c37509a4 /src/runtime/coverage | |
| parent | 1f90bf1adc18da52c6df978f9d896f1ab2f62567 (diff) | |
| download | go-91a716a043f01334e7e6d28af4863d2188ffb336.tar.xz | |
runtime/coverage: fix problematic test from issue 59563
Fix up the coverage testpoint TestIssue59563TruncatedCoverPkgAll
to avoid spurious failures due to racy behavior. Specifically,
we are only interested in verifying coverage for the larger
function of the two in the test package (the smaller one is only
there to trigger additional function registrations while the
test is finalizing the cov data).
Updates #59867.
Updates #59563.
Change-Id: Ibfbbcbf68e0ad7a4d9606cbcfc69d140375c7b87
Reviewed-on: https://go-review.googlesource.com/c/go/+/492175
Run-TryBot: Than McIntosh <thanm@google.com>
Auto-Submit: Than McIntosh <thanm@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: David Chase <drchase@google.com>
Reviewed-by: Cherry Mui <cherryyz@google.com>
Diffstat (limited to 'src/runtime/coverage')
| -rw-r--r-- | src/runtime/coverage/emitdata_test.go | 9 |
1 files changed, 6 insertions, 3 deletions
diff --git a/src/runtime/coverage/emitdata_test.go b/src/runtime/coverage/emitdata_test.go index b0bd0e5c21..3558dd2d88 100644 --- a/src/runtime/coverage/emitdata_test.go +++ b/src/runtime/coverage/emitdata_test.go @@ -527,7 +527,10 @@ func TestIssue59563TruncatedCoverPkgAll(t *testing.T) { if len(f) == 0 { continue } - if !strings.HasPrefix(f[0], "runtime/coverage/testdata/issue59563/repro.go") { + // We're only interested in the specific function "large" for + // the testcase being built. See the #59563 for details on why + // size matters. + if !(strings.HasPrefix(f[0], "runtime/coverage/testdata/issue59563/repro.go") && strings.Contains(line, "large")) { continue } nfound++ @@ -537,8 +540,8 @@ func TestIssue59563TruncatedCoverPkgAll(t *testing.T) { bad = true } } - if nfound != 2 { - t.Errorf("wanted 2 found, got %d\n", nfound) + if nfound != 1 { + t.Errorf("wanted 1 found, got %d\n", nfound) bad = true } if bad { |