diff options
| author | qmuntal <quimmuntal@gmail.com> | 2023-09-04 17:30:08 +0200 |
|---|---|---|
| committer | Quim Muntal <quimmuntal@gmail.com> | 2023-10-05 08:26:52 +0000 |
| commit | bc15070085ec417d4254f8a4eda62b42de88fb37 (patch) | |
| tree | e0678a8d064fc84b978510f7ccc2f52ebb80f51b /src/runtime/cgo | |
| parent | 36ecff0893e8f30c2ff659acf8c62401f4dcebf7 (diff) | |
| download | go-bc15070085ec417d4254f8a4eda62b42de88fb37.tar.xz | |
runtime: support SetUnhandledExceptionFilter on Windows
The Windows unhandled exception mechanism fails to call the callback
set in SetUnhandledExceptionFilter if the stack can't be correctly
unwound.
Some cgo glue code was not properly chaining the frame pointer, making
the stack unwind to fail in case of an exception inside a cgo call.
This CL fix that and adds a test case to avoid regressions.
Fixes #50951
Change-Id: Ic782b5257fe90b05e3def8dbf0bb8d4ed37a190b
Reviewed-on: https://go-review.googlesource.com/c/go/+/525475
Reviewed-by: Bryan Mills <bcmills@google.com>
Reviewed-by: Cherry Mui <cherryyz@google.com>
Run-TryBot: Quim Muntal <quimmuntal@gmail.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Diffstat (limited to 'src/runtime/cgo')
| -rw-r--r-- | src/runtime/cgo/asm_amd64.s | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/runtime/cgo/asm_amd64.s b/src/runtime/cgo/asm_amd64.s index f254622f23..48afe4ef62 100644 --- a/src/runtime/cgo/asm_amd64.s +++ b/src/runtime/cgo/asm_amd64.s @@ -18,7 +18,7 @@ TEXT ·set_crosscall2(SB),NOSPLIT,$0-0 // Saves C callee-saved registers and calls cgocallback with three arguments. // fn is the PC of a func(a unsafe.Pointer) function. // This signature is known to SWIG, so we can't change it. -TEXT crosscall2(SB),NOSPLIT|NOFRAME,$0-0 +TEXT crosscall2(SB),NOSPLIT,$0-0 PUSH_REGS_HOST_TO_ABI0() // Make room for arguments to cgocallback. |