diff options
| author | Matthew Dempsky <mdempsky@google.com> | 2017-03-01 15:50:57 -0800 |
|---|---|---|
| committer | Matthew Dempsky <mdempsky@google.com> | 2017-03-07 20:14:17 +0000 |
| commit | c310c688ffa46e2f91e40284c16d71f3921feed9 (patch) | |
| tree | 4eaf626a618d12018a5ae11be7a17e0634baef47 /src/runtime/asm_amd64.s | |
| parent | 5ed952368e3777845afd934e38219c5567b09cc4 (diff) | |
| download | go-c310c688ffa46e2f91e40284c16d71f3921feed9.tar.xz | |
cmd/compile, runtime: simplify multiway select implementation
This commit reworks multiway select statements to use normal control
flow primitives instead of the previous setjmp/longjmp-like behavior.
This simplifies liveness analysis and should prevent issues around
"returns twice" function calls within SSA passes.
test/live.go is updated because liveness analysis's CFG is more
representative of actual control flow. The case bodies are the only
real successors of the selectgo call, but previously the selectsend,
selectrecv, etc. calls were included in the successors list too.
Updates #19331.
Change-Id: I7f879b103a4b85e62fc36a270d812f54c0aa3e83
Reviewed-on: https://go-review.googlesource.com/37661
Run-TryBot: Matthew Dempsky <mdempsky@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Keith Randall <khr@golang.org>
Diffstat (limited to 'src/runtime/asm_amd64.s')
| -rw-r--r-- | src/runtime/asm_amd64.s | 6 |
1 files changed, 0 insertions, 6 deletions
diff --git a/src/runtime/asm_amd64.s b/src/runtime/asm_amd64.s index 0686449cf6..c6ff8379e6 100644 --- a/src/runtime/asm_amd64.s +++ b/src/runtime/asm_amd64.s @@ -822,12 +822,6 @@ TEXT runtime·getcallerpc(SB),NOSPLIT,$8-16 MOVQ AX, ret+8(FP) RET -TEXT runtime·setcallerpc(SB),NOSPLIT,$8-16 - MOVQ argp+0(FP),AX // addr of first arg - MOVQ pc+8(FP), BX - MOVQ BX, -8(AX) // set calling pc - RET - // func cputicks() int64 TEXT runtime·cputicks(SB),NOSPLIT,$0-0 CMPB runtime·lfenceBeforeRdtsc(SB), $1 |