diff options
| author | Bryan C. Mills <bcmills@google.com> | 2022-11-22 15:31:06 -0500 |
|---|---|---|
| committer | Gopher Robot <gobot@golang.org> | 2022-11-22 21:00:09 +0000 |
| commit | 1fbfc2f6eba6cc88a8fb0ae8e83afe80553f65df (patch) | |
| tree | 56c59a662ec546485799083f283403c19a94c2c2 /src/plugin | |
| parent | bb917bd1b212dc8fff3852fa164667cd06b9f653 (diff) | |
| download | go-1fbfc2f6eba6cc88a8fb0ae8e83afe80553f65df.tar.xz | |
cmd/go: fix the DefaultCC check if CC is an absolute file missing an extension on Windows
This undoes the code (but not test) change from CL 451219, which turns
out to be slightly harmful on Windows (because it doesn't resolve the
file extension for an absolute CC path) and unnecessary elsewhere
(because calling LookPath on a fully-resolved executable path already
stats¹ that path before returning it).
¹https://cs.opensource.google/go/go/+/refs/tags/go1.19.3:src/os/exec/lp_unix.go;l=46;drc=027855e8d86f461b50946b006ea032d4b4a7d817
Change-Id: If8c5ba59cbcc9fc289e9325afb9ccdadf374b102
Reviewed-on: https://go-review.googlesource.com/c/go/+/452777
Reviewed-by: Michael Matloob <matloob@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Russ Cox <rsc@golang.org>
Run-TryBot: Bryan Mills <bcmills@google.com>
Auto-Submit: Bryan Mills <bcmills@google.com>
Diffstat (limited to 'src/plugin')
0 files changed, 0 insertions, 0 deletions