aboutsummaryrefslogtreecommitdiff
path: root/src/pkg/strings/strings.go
diff options
context:
space:
mode:
authorRui Ueyama <ruiu@google.com>2014-06-11 19:03:59 -0700
committerJosh Bleecher Snyder <josharian@gmail.com>2014-06-11 19:03:59 -0700
commit7bcbb65d7879f17b185cee9ab4ab392da0bd865f (patch)
tree32e2589bcc426a1be9cf56e0f4fa5b1738a129b1 /src/pkg/strings/strings.go
parent22a5d2cc961a0f115ebd61f41cabec6e668ed451 (diff)
downloadgo-7bcbb65d7879f17b185cee9ab4ab392da0bd865f.tar.xz
bytes, strings: optimize Repeat
Call copy with as large buffer as possible to reduce the number of function calls. benchmark old ns/op new ns/op delta BenchmarkBytesRepeat 540 162 -70.00% BenchmarkStringsRepeat 563 177 -68.56% LGTM=josharian R=golang-codereviews, josharian, dave, dvyukov CC=golang-codereviews https://golang.org/cl/90550043
Diffstat (limited to 'src/pkg/strings/strings.go')
-rw-r--r--src/pkg/strings/strings.go7
1 files changed, 4 insertions, 3 deletions
diff --git a/src/pkg/strings/strings.go b/src/pkg/strings/strings.go
index 5d46211d84..53bcd6b98a 100644
--- a/src/pkg/strings/strings.go
+++ b/src/pkg/strings/strings.go
@@ -423,9 +423,10 @@ func Map(mapping func(rune) rune, s string) string {
// Repeat returns a new string consisting of count copies of the string s.
func Repeat(s string, count int) string {
b := make([]byte, len(s)*count)
- bp := 0
- for i := 0; i < count; i++ {
- bp += copy(b[bp:], s)
+ bp := copy(b, s)
+ for bp < len(b) {
+ copy(b[bp:], b[:bp])
+ bp *= 2
}
return string(b)
}